Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
STRd6
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was mentioned on Discord that the unplugin doesn't work when a directory (or filename) has a
#character in it, at least with Webpack.This PR should fix that, while still supporting
#as a special suffix character as used in some systems, via a simple heuristic: if the file exists before stripping a#suffix, then don't strip it. (By contrast, we currently strip all#suffixes.)I tested in
integration/unplugin-examples/webpackby changingmodule.civettomod#ule.civet(not committed here). Webpack has a second issue (maybe eventually fixed in unjs/unplugin#592) that#in paths are encoded as\0#. Looking for this as opposed to raw#would be another way to fix this issue, but it'd be specific to Webpack, and it's arguably a bug in unplugin, so I'd rather not rely on it.