Draft
Conversation
Agent-Logs-Url: https://github.com/DanielXMoore/Civet/sessions/681cd95d-4e8c-425c-b6d1-93d02151c17a Co-authored-by: STRd6 <18894+STRd6@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update LSP semantic token provider for syntax highlighting
Add semantic token provider to Civet LSP
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax highlighting via TextMate grammar patching is brittle and incomplete for Civet. Semantic tokens from the parser are the correct long-term solution, giving editors accurate, context-aware highlighting.
Changes
source/semantic-tokens.civet(new)Core token walker. Traverses the pruned AST collecting
{pos, length, group}tuples:node.group→ nodetypefield → inherited parent group (handlesRegularExpressionLiteral,TemplateLiteral) → keyword table lookupToken groups:
"keyword" | "string" | "number" | "regexp" | "operator" | "comment" | "type"source/parser/types.civetAdds optional
group?: stringtoASTLeafso the parser can explicitly annotate tokens in the future (as suggested in the issue) without requiring inference.source/main.civet+types/types.d.tsExports
getSemanticTokens,SemanticToken, andTokenGroupfrom the public API.lsp/source/server.mtssemanticTokensProvidercapability with a 7-type legendtextDocument/semanticTokens/fullfor.civetfiles: parses source, walks AST, converts byte offsets to line/character positions, returns LSP delta-encodeddataarraytest/semantic-tokens.civet(new)13 tests covering keywords, all literal types, comments, sort order, and zero-length filtering.