Add auto unclaim feature by Copilot · Pull Request #1918 · Dans-Plugins/Medieval-Factions

Copilot · 2025-12-13T05:25:49Z

Implementation Notes

Follows the same pattern as autoclaim feature for consistency
All language files updated (en_US, en_GB, de_DE, fr_FR, pt_BR)
Permission check follows existing codebase pattern (uses OR logic like other commands)
Database migration V9 adds autounclaim column
JOOQ classes will need regeneration when project can be built
Autounclaim logic now properly contained within single playerFaction null check

Original prompt

This section details on the original issue you should resolve

<issue_title>Auto unclaim feature</issue_title>
<issue_description>To go along with the auto claim feature, this would be very a very welcome addition.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Auto unclaim feature #1666

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot

Pull request overview

This pull request implements an auto unclaim feature that mirrors the existing auto claim functionality. When enabled via /faction unclaim auto, faction members with appropriate permissions can walk through their faction's territory to automatically unclaim chunks.

Changes:

Added database migration to add autounclaim boolean column to mf_faction table
Extended MfFaction data model and repository with autounclaim field
Refactored MfFactionUnclaimCommand to support subcommands, creating separate MfFactionUnclaimAutoCommand and MfFactionUnclaimCircleCommand classes
Added autounclaim trigger logic to PlayerMoveListener to detect and delete claims when players enter their faction's territory
Added TOGGLE_AUTOUNCLAIM faction permission and corresponding Bukkit permissions
Added translations for all new messages across 5 supported languages (English US/GB, French, Portuguese BR, German)

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
V9__Add_autounclaim.sql	Database migration adding autounclaim boolean column with default false
MfFaction.kt	Added autounclaim boolean field to faction data model
JooqMfFactionRepository.kt	Updated persistence layer to save/load autounclaim field
MfFactionUnclaimCommand.kt	Refactored to delegate to subcommands (auto/circle pattern)
MfFactionUnclaimAutoCommand.kt	New command to toggle autounclaim for faction
MfFactionUnclaimCircleCommand.kt	Extracted original unclaim logic to separate class
PlayerMoveListener.kt	Added autounclaim trigger logic when entering owned chunks
MfFactionPermissions.kt	Added TOGGLE_AUTOUNCLAIM permission
MfFactionHelpCommand.kt	Added autounclaim help text to command list
lang_*.properties (x5)	Added translations for autounclaim messages in all 5 languages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-01T12:17:12Z

src/main/resources/lang/lang_en_US.properties

 CommandFactionHelpFaction=/faction - Faction management commands
 CommandFactionHelpFactionAlly=/faction ally [faction] - Ally with a given faction
 CommandFactionHelpFactionAutoclaim=/faction autoclaim - Enable autoclaim for your faction
+CommandFactionHelpFactionAutounclaim=/faction autounclaim - Enable autounclaim for your faction


The help text shows /faction autounclaim but the actual command structure is /faction unclaim auto based on the implementation in MfFactionUnclaimCommand.kt. The help text should be corrected to /faction unclaim auto to match the actual command structure.

Suggested change

CommandFactionHelpFactionAutounclaim=/faction autounclaim - Enable autounclaim for your faction

CommandFactionHelpFactionAutounclaim=/faction unclaim auto - Enable autounclaim for your faction

Fixed in cc7dfac - Changed help text to /faction unclaim auto

Copilot · 2026-02-01T12:17:13Z

src/main/resources/lang/lang_en_GB.properties

 CommandFactionHelpFaction=/faction - Faction management commands
 CommandFactionHelpFactionAlly=/faction ally [faction] - Ally with a given faction
 CommandFactionHelpFactionAutoclaim=/faction autoclaim - Enable autoclaim for your faction
+CommandFactionHelpFactionAutounclaim=/faction autounclaim - Enable autounclaim for your faction


The help text shows /faction autounclaim but the actual command structure is /faction unclaim auto. The help text should be corrected to /faction unclaim auto to match the actual command structure.

Suggested change

CommandFactionHelpFactionAutounclaim=/faction autounclaim - Enable autounclaim for your faction

CommandFactionHelpFactionAutounclaim=/faction unclaim auto - Enable autounclaim for your faction

Fixed in cc7dfac - Changed help text to /faction unclaim auto

Copilot · 2026-02-01T12:17:13Z

src/main/resources/lang/lang_fr_FR.properties

 CommandFactionHelpFaction=/faction - Commandes de gestion de faction
 CommandFactionHelpFactionAlly=/faction ally [faction] - S''allier � une faction donn�e
 CommandFactionHelpFactionAutoclaim=/faction autoclaim - Activer l''autoclaim pour votre faction
+CommandFactionHelpFactionAutounclaim=/faction autounclaim - Activer l''autounclaim pour votre faction


The help text shows /faction autounclaim but the actual command structure is /faction unclaim auto. The help text should be corrected to /faction unclaim auto to match the actual command structure.

Suggested change

CommandFactionHelpFactionAutounclaim=/faction autounclaim - Activer l''autounclaim pour votre faction

CommandFactionHelpFactionAutounclaim=/faction unclaim auto - Activer l''autounclaim pour votre faction

Fixed in cc7dfac - Changed help text to /faction unclaim auto

Copilot · 2026-02-01T12:17:13Z

src/main/resources/lang/lang_pt_BR.properties

 CommandFactionHelpFaction=/faction - Comandos de gerenciamento de facção
 CommandFactionHelpFactionAlly=/faction ally [faction] - Aliar-se a uma determinada facção
 CommandFactionHelpFactionAutoclaim=/faction autoclaim - Ative a reivindicação automática para sua facção
+CommandFactionHelpFactionAutounclaim=/faction autounclaim - Ative a desreivindicação automática para sua facção


The help text shows /faction autounclaim but the actual command structure is /faction unclaim auto. The help text should be corrected to /faction unclaim auto to match the actual command structure.

Suggested change

CommandFactionHelpFactionAutounclaim=/faction autounclaim - Ative a desreivindicação automática para sua facção

CommandFactionHelpFactionAutounclaim=/faction unclaim auto - Ative a desreivindicação automática para sua facção

Fixed in cc7dfac - Changed help text to /faction unclaim auto

Copilot · 2026-02-01T12:17:14Z

src/main/resources/lang/lang_de_DE.properties

-CommandFactionHelpFactionAutoclaim=/fraktion autoanspruch - Aktiviere den Autoanspruch f�r deine Fraktion
+CommandFactionHelpFactionAlly=/fraktion verb�ndeter [faction] - Verb�nde dich mit einer bestimmten Fraktion
+CommandFactionHelpFactionAutoclaim=/fraktion autoanspruch - Aktiviere den Autoanspruch f�r deine Fraktion
+CommandFactionHelpFactionAutounclaim=/fraktion autoaufhebung - Aktiviere die Autoaufhebung f�r deine Fraktion


The help text shows /fraktion autoaufhebung but the actual command structure is /fraktion deklarieren auto (based on the English equivalent /faction unclaim auto). The help text should be corrected to match the actual command structure.

Suggested change

CommandFactionHelpFactionAutounclaim=/fraktion autoaufhebung - Aktiviere die Autoaufhebung f�r deine Fraktion

CommandFactionHelpFactionAutounclaim=/fraktion deklarieren auto - Aktiviere die Autoaufhebung f�r deine Fraktion

Fixed in cc7dfac - Changed help text to /fraktion deklarieren auto

Copilot · 2026-02-01T12:17:14Z

src/main/kotlin/com/dansplugins/factionsystem/listener/PlayerMoveListener.kt

+                    if (newChunkClaim != null && newChunkClaim.factionId.value == playerFaction.id.value && playerFaction.autounclaim) {
+                        val playerRole = playerFaction.getRole(mfPlayer.id) ?: return@Runnable
+                        val unclaimPermissionValue = playerRole.getPermissionValue(plugin.factionPermissions.unclaim) ?: return@Runnable
+                        if (!unclaimPermissionValue || !event.player.hasPermission("mf.unclaim")) {


The permission check on line 95 verifies both the faction permission (unclaimPermissionValue) and the Bukkit permission (mf.unclaim). However, this check returns early silently if the player lacks permissions. When autounclaim is enabled but the player lacks permissions, they will walk through their territory without any feedback that autounclaim failed due to insufficient permissions. Consider adding a message to inform the player why autounclaim didn't work, similar to how autoclaim shows messages when it's automatically disabled due to power limits or contiguity issues.

Suggested change

if (!unclaimPermissionValue || !event.player.hasPermission("mf.unclaim")) {

if (!unclaimPermissionValue || !event.player.hasPermission("mf.unclaim")) {

plugin.server.scheduler.runTask(

plugin,

Runnable {

event.player.sendMessage("${RED}You do not have permission to automatically unclaim territory.")

}

)

Copilot · 2026-02-01T12:17:14Z

src/main/kotlin/com/dansplugins/factionsystem/listener/PlayerMoveListener.kt

+                if (playerFaction != null) {
+                    if (newChunkClaim != null && newChunkClaim.factionId.value == playerFaction.id.value && playerFaction.autounclaim) {
+                        val playerRole = playerFaction.getRole(mfPlayer.id) ?: return@Runnable
+                        val unclaimPermissionValue = playerRole.getPermissionValue(plugin.factionPermissions.unclaim) ?: return@Runnable
+                        if (!unclaimPermissionValue || !event.player.hasPermission("mf.unclaim")) {
+                            return@Runnable
+                        }
+                        claimService.delete(newChunkClaim).onFailure {
+                            plugin.logger.log(SEVERE, "Failed to delete chunk claim: ${it.reason.message}", it.reason.cause)
+                            return@Runnable
+                        }
+                    }
+                }


The null check for playerFaction on line 91 is redundant. The variable playerFaction is already checked for null on line 40, and between lines 40-90, there's no code that could make it null again (it's a val, not reassigned). The autounclaim block could be merged into the same if-block as the autoclaim logic on line 40, or at minimum, this redundant null check should be removed.

Fixed in cc7dfac - Removed redundant null check by merging autounclaim logic into the same if-block as autoclaim (line 40)

dmccoystephenson · 2026-02-01T12:22:40Z

@copilot address comments

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Initial plan

3ab7be6

Copilot AI assigned Copilot and dmccoystephenson Dec 13, 2025

Copilot started work on behalf of dmccoystephenson December 13, 2025 05:26 View session

Add auto unclaim feature implementation

0471654

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add auto unclaim feature~~ Add auto unclaim feature Dec 13, 2025

Copilot AI requested a review from dmccoystephenson December 13, 2025 05:43

Copilot finished work on behalf of dmccoystephenson December 13, 2025 05:43

dmccoystephenson requested a review from Copilot February 1, 2026 12:11

Copilot started reviewing on behalf of dmccoystephenson February 1, 2026 12:12 View session

Copilot AI reviewed Feb 1, 2026

View reviewed changes

Copilot started work on behalf of dmccoystephenson February 1, 2026 12:23 View session

Fix help text and remove redundant null check in autounclaim

cc7dfac

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot finished work on behalf of dmccoystephenson February 1, 2026 12:25

	CommandFactionHelpFactionAutounclaim=/faction autounclaim - Enable autounclaim for your faction
	CommandFactionHelpFactionAutounclaim=/faction unclaim auto - Enable autounclaim for your faction

	CommandFactionHelpFactionAutounclaim=/fraktion autoaufhebung - Aktiviere die Autoaufhebung f�r deine Fraktion
	CommandFactionHelpFactionAutounclaim=/fraktion deklarieren auto - Aktiviere die Autoaufhebung f�r deine Fraktion

-                        if (!unclaimPermissionValue || !event.player.hasPermission("mf.unclaim")) {
+                        if (!unclaimPermissionValue || !event.player.hasPermission("mf.unclaim")) {
+                            plugin.server.scheduler.runTask(
+                                plugin,
+                                Runnable {
+                                    event.player.sendMessage("${RED}You do not have permission to automatically unclaim territory.")
+                                }
+                            )

Conversation

Copilot AI commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation Notes

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

dmccoystephenson commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 13, 2025 •

edited

Loading