Robot Upgrade: submariner-k8s-broker chart upgrade from 0.19.2 to 0.22.1#3916
Robot Upgrade: submariner-k8s-broker chart upgrade from 0.19.2 to 0.22.1#3916weizhoublue wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine upgrade of the submariner-k8s-broker Helm chart to a newer version. The primary impact of this upgrade is the modernization and enhancement of the Custom Resource Definitions, which define the API objects used by Submariner. Additionally, the chart's internal structure for managing RBAC and service accounts has been streamlined, making their creation implicit rather than configurable through values. These changes ensure compatibility with newer Kubernetes features and improve the overall robustness of the chart. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the upgrade of the submariner-k8s-broker chart from version 0.19.2 to 0.22.1. The changes primarily involve version bumps, significant updates to the Custom Resource Definitions (CRDs) to align with the new API version, and refactoring of the Helm templates. A notable change is the removal of conditional logic for creating RBAC and ServiceAccount resources, making them unconditional, which simplifies the chart but is a breaking change. My review identified a regression in the refactored Role resource where standard Helm labels were omitted. I've provided a suggestion to re-add them to ensure proper resource tracking by Helm.
| metadata: | ||
| name: {{ template "submariner-k8s-broker.fullname" . }}-cluster |
There was a problem hiding this comment.
The standard Helm labels (heritage, release, chart, app) are missing from this Role resource. These labels were present in the previous version of the chart and are important for resource management with Helm. Please add them back to the metadata to maintain consistency and best practices.
metadata:
name: {{ template "submariner-k8s-broker.fullname" . }}-cluster
labels:
heritage: {{ .Release.Service | quote }}
release: {{ .Release.Name | quote }}
chart: {{ template "submariner-k8s-broker.chart" . }}
app: {{ template "submariner-k8s-broker.name" . }}
github-actions
bot
force-pushed
the
upgrade/submariner-k8s-broker/0.22.1
branch
8 times, most recently
from
97d0261 to
623d9a8
Compare
…22.1 Signed-off-by: robot <robot@example.com>
github-actions
bot
force-pushed
the
upgrade/submariner-k8s-broker/0.22.1
branch
from
623d9a8 to
a14933f
Compare
2 participants
I am robot, upgrade: project submariner-k8s-broker chart upgrade from 0.19.2 to 0.22.1