Skip to content

Comments

Robot Upgrade: argo-rollouts chart upgrade from 2.39.6 to 2.40.6#3925

Open
weizhoublue wants to merge 1 commit intomainfrom
upgrade/argo-rollouts/2.40.6
Open

Robot Upgrade: argo-rollouts chart upgrade from 2.39.6 to 2.40.6#3925
weizhoublue wants to merge 1 commit intomainfrom
upgrade/argo-rollouts/2.40.6

Conversation

@weizhoublue
Copy link
Member

I am robot, upgrade: project argo-rollouts chart upgrade from 2.39.6 to 2.40.6

@gemini-code-assist
Copy link

Summary of Changes

Hello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Argo Rollouts Helm chart to its latest version, incorporating several new configuration options. These enhancements provide greater control over deployment specifics, including the ability to override the target namespace, configure DNS settings for core components, and secure Prometheus metrics scraping with TLS. The changes aim to improve the chart's adaptability and operational security.

Highlights

  • Argo Rollouts Chart Upgrade: The Helm chart for Argo Rollouts has been upgraded from version 2.39.6 to 2.40.6, aligning with the Argo Rollouts application version v1.8.4.
  • Namespace Override Capability: A new namespaceOverride parameter was introduced, allowing users to explicitly define the namespace for deployed resources, enhancing deployment flexibility.
  • DNS Configuration Options: Added global.dnsConfig to allow specifying DNS settings for controller and dashboard deployments.
  • Prometheus ServiceMonitor TLS: Support for TLS configuration (controller.metrics.serviceMonitor.tlsConfig) was added to the Prometheus ServiceMonitor, improving security for metrics scraping.
  • Ingress Port Handling Improvement: The ingress template logic was refined to correctly handle both string and numeric service port definitions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • charts/argo-rollouts/argo-rollouts/Chart.yaml
    • Updated the chart version from 2.39.6 to 2.40.6.
    • Updated the appVersion from v1.8.3 to v1.8.4.
  • charts/argo-rollouts/argo-rollouts/README.md
    • Documented the new global.dnsConfig parameter.
    • Documented the new namespaceOverride parameter.
    • Documented the new controller.metrics.serviceMonitor.tlsConfig parameter.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/Chart.yaml
    • Updated the chart version from 2.39.6 to 2.40.6.
    • Updated the appVersion from v1.8.3 to v1.8.4.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/README.md
    • Documented the new global.dnsConfig parameter.
    • Documented the new namespaceOverride parameter.
    • Documented the new controller.metrics.serviceMonitor.tlsConfig parameter.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/_helpers.tpl
    • Added a new helper template argo-rollouts.namespace to manage namespace overriding.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/clusterrolebinding.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/configmap.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/deployment.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
    • Added support for global.dnsConfig in the controller deployment.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/metrics-service.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/notifications-configmap.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/notifications-secret.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/poddisruptionbudget.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/role.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/rolebinding.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/serviceaccount.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/controller/servicemonitor.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
    • Added support for controller.metrics.serviceMonitor.tlsConfig.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/dashboard/clusterrolebinding.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/dashboard/deployment.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
    • Added support for global.dnsConfig in the dashboard deployment.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/dashboard/ingress.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
    • Modified the ingress port handling logic to differentiate between string and numeric service ports.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/dashboard/poddisruptionbudget.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/dashboard/service.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
    • Changed the dashboard service targetPort to a named port.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/templates/dashboard/serviceaccount.yaml
    • Updated the namespace reference to use the new argo-rollouts.namespace helper.
  • charts/argo-rollouts/argo-rollouts/charts/argo-rollouts/values.yaml
    • Added namespaceOverride parameter.
    • Added global.dnsConfig parameter.
    • Added controller.metrics.serviceMonitor.tlsConfig parameter.
    • Updated image tags for controller and dashboard to v1.8.4.
  • charts/argo-rollouts/argo-rollouts/values.yaml
    • Added namespaceOverride parameter.
    • Added global.dnsConfig parameter.
    • Added controller.metrics.serviceMonitor.tlsConfig parameter.
    • Updated image tags for controller and dashboard to v1.8.4.
  • charts/argo-rollouts/config
    • Updated the VERSION environment variable to 2.40.6.
Activity
  • The pull request was created by weizhoublue to upgrade the argo-rollouts chart.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the argo-rollouts Helm chart from version 2.39.6 to 2.40.6, which includes updating the appVersion to v1.8.4. The changes introduce new features like namespaceOverride, global.dnsConfig, and tlsConfig for the service monitor, and refactor the chart to use them. The updates are applied consistently across the main chart and sub-chart. Overall, the changes are correct and improve the chart's functionality.

@github-actions github-actions bot force-pushed the upgrade/argo-rollouts/2.40.6 branch 5 times, most recently from e43b276 to ba10d99 Compare February 19, 2026 20:09
Signed-off-by: robot <robot@example.com>
@github-actions github-actions bot force-pushed the upgrade/argo-rollouts/2.40.6 branch from ba10d99 to aa6f2c6 Compare February 20, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants