Robot Upgrade: argo-cd chart upgrade from 8.1.0 to 9.4.3#3932
Open
weizhoublue wants to merge 1 commit intomainfrom
Open
Robot Upgrade: argo-cd chart upgrade from 8.1.0 to 9.4.3#3932weizhoublue wants to merge 1 commit intomainfrom
weizhoublue wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the Argo CD Helm chart, moving from version 8.1.0 to 9.4.3. This update encompasses a bump in the underlying Argo CD application version to v3.3.1 and its Redis-HA dependency to 4.34.11. The changes introduce expanded support for modern Kubernetes networking constructs like the Gateway API and AKS Application Routing, alongside a suite of new configuration parameters for finer control over deployment labels, resource autoscaling, and network policies. The update also includes improvements to Redis stability and general chart maintenance. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the argo-cd chart from version 8.1.0 to 9.4.3, bumping the appVersion to v3.3.1 and updating its dependencies. It introduces new features such as VPA support and Gateway API integration, with corresponding documentation updates. A critical security concern has been identified: a potential command injection vulnerability in the redis-ha subchart templates, where a Helm value is directly injected into a shell script used for split-brain detection. Furthermore, a critical typo in a new template and minor grammatical and consistency issues in the documentation need to be addressed.
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} | ||
| {{- with .Values.controller.vpa.annotations }} | ||
| annnotaions: |
There was a problem hiding this comment.
There is a typo in the key annnotaions. It should be annotations. This will prevent any annotations from being applied to the VerticalPodAutoscaler resource.
annotations:| if [ "$ROLE" != "master" ]; then | ||
| reinit | ||
| echo "waiting for redis to become master" | ||
| sleep {{ .Values.splitBrainDetection.retryInterval }} |
There was a problem hiding this comment.
The template directly injects the value of .Values.splitBrainDetection.retryInterval into a shell script without any validation or quoting. If an attacker can control this Helm value (e.g., via an Argo CD Application override), they can achieve arbitrary command execution within the container by providing a value like 10; touch /tmp/pwned.
Recommendation: Ensure the value is a number by casting it to an integer in the template.
sleep {{ .Values.splitBrainDetection.retryInterval | int }}
| if [ "$REDIS_MASTER" != "$MASTER" ]; then | ||
| reinit | ||
| echo "Redis master and local master are not the same. waiting." | ||
| sleep {{ .Values.splitBrainDetection.retryInterval }} |
There was a problem hiding this comment.
The template directly injects the value of .Values.splitBrainDetection.retryInterval into a shell script without any validation or quoting. If an attacker can control this Helm value (e.g., via an Argo CD Application override), they can achieve arbitrary command execution within the container by providing a value like 10; touch /tmp/pwned.
Recommendation: Ensure the value is a number by casting it to an integer in the template.
sleep {{ .Values.splitBrainDetection.retryInterval | int }}
| Highlighted versions provide information about additional steps that should be performed by user when upgrading to newer version. | ||
|
|
||
| ### 9.1.0 | ||
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated ArgoCD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. |
There was a problem hiding this comment.
For consistency with the rest of the document and the project's official name, ArgoCD should be written as Argo CD.
Suggested change
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated ArgoCD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. | |
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated Argo CD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. |
| ### 9.1.0 | ||
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated ArgoCD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. | ||
|
|
||
| > Note: If server-side diffing is enabled, you will need to revert this to use client-side diffing, otherwise ArgoCD will be in an Unknown status. More information [here](https://github.com/argoproj/argo-cd/issues/25184). If you happened to upgrade this helm chart before configuring client-side diffing, you will need to delete (orphaning children) the `argocd-redis-ha-haproxy` deployment; once the newest deployment has rolled out, its suggested to cleanup the orphaned ReplicaSets |
There was a problem hiding this comment.
There's a grammatical error here. its is possessive, but it's (a contraction of "it is") is needed for "it is suggested".
Suggested change
| > Note: If server-side diffing is enabled, you will need to revert this to use client-side diffing, otherwise ArgoCD will be in an Unknown status. More information [here](https://github.com/argoproj/argo-cd/issues/25184). If you happened to upgrade this helm chart before configuring client-side diffing, you will need to delete (orphaning children) the `argocd-redis-ha-haproxy` deployment; once the newest deployment has rolled out, its suggested to cleanup the orphaned ReplicaSets | |
| > Note: If server-side diffing is enabled, you will need to revert this to use client-side diffing, otherwise ArgoCD will be in an Unknown status. More information [here](https://github.com/argoproj/argo-cd/issues/25184). If you happened to upgrade this helm chart before configuring client-side diffing, you will need to delete (orphaning children) the `argocd-redis-ha-haproxy` deployment; once the newest deployment has rolled out, it's suggested to cleanup the orphaned ReplicaSets |
| We have removed all parameters under `.Values.configs.params` in this release, with the exception of `create` and `annotations`. | ||
| This is to ensure better alignment with the upstream project, as tracking changes to their default values within the Helm chart has become challenging. | ||
|
|
||
| **Though we removed the parameters from values.yaml in argo-helm, we keep providing the interface to override `.Values.configs.params` as the same way. ** |
There was a problem hiding this comment.
The phrase "as the same way" is grammatically incorrect. It should be "in the same way" for better clarity.
Suggested change
| **Though we removed the parameters from values.yaml in argo-helm, we keep providing the interface to override `.Values.configs.params` as the same way. ** | |
| **Though we removed the parameters from values.yaml in argo-helm, we keep providing the interface to override `.Values.configs.params` in the same way. ** |
| Highlighted versions provide information about additional steps that should be performed by user when upgrading to newer version. | ||
|
|
||
| ### 9.1.0 | ||
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated ArgoCD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. |
There was a problem hiding this comment.
For consistency with the rest of the document and the project's official name, ArgoCD should be written as Argo CD.
Suggested change
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated ArgoCD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. | |
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated Argo CD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. |
| ### 9.1.0 | ||
| This chart contains a breaking change (if using `redis-ha`), which was introduced by the dependency `redis-ha` (as seen [here](https://github.com/DandyDeveloper/charts/blob/a03b6a6f4d72b6606ce9a218c7d0026350b48ad0/charts/redis-ha/README.md#4341---upgrade-may-complain-about-selector-label-changes-being-immutable)). The upgrade will complain about selector label changes being immutable, which requires a replacement of the `argocd-redis-ha-haproxy` deployment. To overcome this, you will need to delete (orphaning children) this deployment, updated ArgoCD to disable server-side diffing, then allow the new deployment of `argocd-redis-ha-haproxy` to rollout with the updated label selectors. | ||
|
|
||
| > Note: If server-side diffing is enabled, you will need to revert this to use client-side diffing, otherwise ArgoCD will be in an Unknown status. More information [here](https://github.com/argoproj/argo-cd/issues/25184). If you happened to upgrade this helm chart before configuring client-side diffing, you will need to delete (orphaning children) the `argocd-redis-ha-haproxy` deployment; once the newest deployment has rolled out, its suggested to cleanup the orphaned ReplicaSets |
There was a problem hiding this comment.
There's a grammatical error here. its is possessive, but it's (a contraction of "it is") is needed for "it is suggested".
Suggested change
| > Note: If server-side diffing is enabled, you will need to revert this to use client-side diffing, otherwise ArgoCD will be in an Unknown status. More information [here](https://github.com/argoproj/argo-cd/issues/25184). If you happened to upgrade this helm chart before configuring client-side diffing, you will need to delete (orphaning children) the `argocd-redis-ha-haproxy` deployment; once the newest deployment has rolled out, its suggested to cleanup the orphaned ReplicaSets | |
| > Note: If server-side diffing is enabled, you will need to revert this to use client-side diffing, otherwise ArgoCD will be in an Unknown status. More information [here](https://github.com/argoproj/argo-cd/issues/25184). If you happened to upgrade this helm chart before configuring client-side diffing, you will need to delete (orphaning children) the `argocd-redis-ha-haproxy` deployment; once the newest deployment has rolled out, it's suggested to cleanup the orphaned ReplicaSets |
| We have removed all parameters under `.Values.configs.params` in this release, with the exception of `create` and `annotations`. | ||
| This is to ensure better alignment with the upstream project, as tracking changes to their default values within the Helm chart has become challenging. | ||
|
|
||
| **Though we removed the parameters from values.yaml in argo-helm, we keep providing the interface to override `.Values.configs.params` as the same way. ** |
There was a problem hiding this comment.
The phrase "as the same way" is grammatically incorrect. It should be "in the same way" for better clarity.
Suggested change
| **Though we removed the parameters from values.yaml in argo-helm, we keep providing the interface to override `.Values.configs.params` as the same way. ** | |
| **Though we removed the parameters from values.yaml in argo-helm, we keep providing the interface to override `.Values.configs.params` in the same way. ** |
github-actions
bot
force-pushed
the
upgrade/argo-cd/9.4.3
branch
from
94b01b6 to
a8d39d0
Compare
Signed-off-by: robot <robot@example.com>
github-actions
bot
force-pushed
the
upgrade/argo-cd/9.4.3
branch
from
a8d39d0 to
2086629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am robot, upgrade: project argo-cd chart upgrade from 8.1.0 to 9.4.3