Robot Upgrade: prometheus-adapter chart upgrade from 4.10.0 to 5.3.0#3936
Robot Upgrade: prometheus-adapter chart upgrade from 4.10.0 to 5.3.0#3936weizhoublue wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: robot <robot@example.com>
Summary of ChangesHello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates the prometheus-adapter Helm chart from version 4.10.0 to 5.3.0. This involves updating version numbers in config and Chart.yaml files, modifying the README.md to reflect new installation methods (OCI Artifacts) and Kubernetes version requirements (1.21+), and updating the Prometheus query syntax in values.yaml. Additionally, it removes PodSecurityPolicy related templates and values, and introduces new fields for revisionHistoryLimit in deployments and cert-manager configurations, and automountServiceAccountToken for service accounts. The changes align with the new chart version's features and deprecations.
| - Helm Repository: `https://prometheus-community.github.io/helm-charts` with chart `prometheus-adapter` | ||
|
|
||
| _See [`helm repo`](https://helm.sh/docs/helm/helm_repo/) for command documentation._ | ||
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. |
There was a problem hiding this comment.
There's a typo in the markdown link for helm repo. It appears to be nested incorrectly, resulting in a broken link. It should be [helm repo](https://helm.sh/docs/helm/helm_repo/).
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. | |
| The installation instructions use the OCI registry. Refer to the [`helm repo`](https://helm.sh/docs/helm/helm_repo/) command documentation for information on installing charts via the traditional repository. |
| - Helm Repository: `https://prometheus-community.github.io/helm-charts` with chart `prometheus-adapter` | ||
|
|
||
| _See [`helm repo`](https://helm.sh/docs/helm/helm_repo/) for command documentation._ | ||
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. |
There was a problem hiding this comment.
The markdown link for helm repo is malformed. It seems like there's an extra [helm repo] around the actual link, which will cause it to render incorrectly. Please correct the syntax.
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. | |
| The installation instructions use the OCI registry. Refer to the [`helm repo`](https://helm.sh/docs/helm/helm_repo/) command documentation for information on installing charts via the traditional repository. |
2 participants
I am robot, upgrade: project prometheus-adapter chart upgrade from 4.10.0 to 5.3.0