Open
Conversation
Summary of ChangesHello @cyclinder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Helm chart for Higress, a cloud-native API gateway, designed to simplify its deployment and management on Kubernetes. The chart includes the core gateway functionality, a management console, and optional integrations for observability (Grafana, Prometheus, Loki, Promtail) and certificate management (cert-manager). Automated scripting handles configuration adjustments and image repository normalization, ensuring a robust and flexible deployment process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Helm chart for Higress. The changes are quite extensive, including the chart structure, subcharts, configuration files, and test scripts. The core logic for customizing the chart resides in custom.sh. My review focuses on this script, where I've identified opportunities to improve robustness and maintainability. Specifically, I'm suggesting a simplification for extracting the chart version and a significant cleanup of the sed commands used for patching YAML files.
charts/higress/custom.sh
Outdated
|
|
||
| mv "$TMP_VALUES_YAML" values.yaml | ||
|
|
||
| export CHART_VERSION=$(helm show chart . | grep '^version' |grep -E '[0-9].*.[0-9]' | awk -F ':' '{print $2}' | tr -d ' ') |
There was a problem hiding this comment.
The command to extract CHART_VERSION is overly complex and can be simplified by using yq, which is already a dependency of this script. This improves readability and robustness.
Suggested change
| export CHART_VERSION=$(helm show chart . | grep '^version' |grep -E '[0-9].*.[0-9]' | awk -F ':' '{print $2}' | tr -d ' ') | |
| export CHART_VERSION=$(yq e '.version' Chart.yaml) |
cyclinder
force-pushed
the
gateway_api
branch
10 times, most recently
from
d866b9f to
ad8cfbb
Compare
Signed-off-by: Cyclinder Kuo <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
gateway_api
branch
from
ad8cfbb to
127d09b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #