Conversation
Summary of ChangesHello @cyclinder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the deployment and management of the kgateway API gateway by introducing a new, comprehensive Helm chart. The chart bundles necessary Kubernetes Gateway API CRDs and custom kgateway CRDs, facilitating a robust and extensible traffic management solution. It also includes dynamic configuration capabilities and improved support for OCI registries, simplifying the installation process and ensuring proper setup of all components. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Helm chart for kgateway, including subcharts for CRDs and scripts for chart generation. The changes are extensive and well-structured. My review focuses on correctness, maintainability, and robustness. I have identified a few areas for improvement: a typo in a configuration file, code duplication in a shell script, a potential deployment failure if resource limits are not provided, and inconsistent naming for RBAC resources. I've provided specific suggestions to address these points in the review comments.
I am having trouble creating individual review comments. Click here to see my feedback.
charts/kgateway/kgateway/charts/kgateway/templates/deployment.yaml (72-81)
The deployment will fail with a CreateContainerConfigError if resources.limits.memory or resources.limits.cpu are not set, because the GOMEMLIMIT and GOMAXPROCS environment variables are trying to reference them. To make the chart more robust, you should wrap these environment variable definitions in if blocks to only set them if the corresponding limits are defined.
{{- if .Values.resources.limits.memory }}
- name: GOMEMLIMIT
valueFrom:
resourceFieldRef:
divisor: "1"
resource: limits.memory
{{- end }}
{{- if .Values.resources.limits.cpu }}
- name: GOMAXPROCS
valueFrom:
resourceFieldRef:
divisor: "1"
resource: limits.cpu
{{- end }}charts/kgateway/config (11)
There is a typo in the variable name UPGRADE_REVIWER. It should be UPGRADE_REVIEWER.
export UPGRADE_REVIEWER=cyclinder
charts/kgateway/kgateway/charts/kgateway/templates/role.yaml (5)
The name of this ClusterRole is constructed manually. For consistency with Helm best practices and other resources in this chart, it's better to use the kgateway.fullname helper. This also makes it easier to override the name if needed and avoids potential naming conflicts.
name: {{ include "kgateway.fullname" . }}charts/kgateway/kgateway/charts/kgateway/templates/serviceaccount.yaml (18-26)
The naming of the ClusterRoleBinding and the reference to the ClusterRole are inconsistent. It's recommended to use the kgateway.fullname helper for naming both the ClusterRole (in role.yaml) and this ClusterRoleBinding for consistency and to follow Helm best practices. The roleRef should also be updated to use the same helper.
name: {{ include "kgateway.fullname" . }}
subjects:
- kind: ServiceAccount
name: {{ include "kgateway.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
name: {{ include "kgateway.fullname" . }}
apiGroup: rbac.authorization.k8s.ioscripts/generateChart.sh (82-103)
This block of logic for handling OCI repositories seems to be duplicated later in the script (lines 113-117). Also, the logic for determining DEP_REPO_URL is duplicated (lines 174-177 and 183-186). To improve maintainability and readability, consider refactoring this logic into a function or setting variables at the beginning of the script and reusing them.
Signed-off-by: Cyclinder Kuo <qifeng.guo@daocloud.io>
1 participant
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #