Robot Upgrade: prometheus-node-exporter chart upgrade from 4.6.0 to 4.52.0#3953
Robot Upgrade: prometheus-node-exporter chart upgrade from 4.6.0 to 4.52.0#3953weizhoublue wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a substantial upgrade to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the prometheus-node-exporter Helm chart from version 4.6.0 to 4.52.0. This is a significant update, incorporating numerous features and improvements from the upstream chart, such as kube-rbac-proxy support, PodMonitor resources, and the removal of deprecated PodSecurityPolicy objects. The changes are well-aligned with the upstream chart. My review includes a minor suggestion to improve consistency in the configuration of container image digests.
| {{- if .Values.kubeRBACProxy.image.sha }} | ||
| image: "{{ .Values.global.imageRegistry | default .Values.kubeRBACProxy.image.registry}}/{{ .Values.kubeRBACProxy.image.repository }}:{{ .Values.kubeRBACProxy.image.tag }}@sha256:{{ .Values.kubeRBACProxy.image.sha }}" | ||
| {{- else }} | ||
| image: "{{ .Values.global.imageRegistry | default .Values.kubeRBACProxy.image.registry}}/{{ .Values.kubeRBACProxy.image.repository }}:{{ .Values.kubeRBACProxy.image.tag }}" | ||
| {{- end }} |
There was a problem hiding this comment.
For consistency with how the main node-exporter image is handled in _helpers.tpl, the kube-rbac-proxy image should use digest instead of sha. The digest field is expected to contain the full digest string including the algorithm (e.g., sha256:...). This also makes the template more flexible if a different hash algorithm is used in the future.
{{- if .Values.kubeRBACProxy.image.digest }}
image: "{{ .Values.global.imageRegistry | default .Values.kubeRBACProxy.image.registry}}/{{ .Values.kubeRBACProxy.image.repository }}:{{ .Values.kubeRBACProxy.image.tag }}@{{ .Values.kubeRBACProxy.image.digest }}"
{{- else }}
image: "{{ .Values.global.imageRegistry | default .Values.kubeRBACProxy.image.registry}}/{{ .Values.kubeRBACProxy.image.repository }}:{{ .Values.kubeRBACProxy.image.tag }}"
{{- end }}| registry: quay.io | ||
| repository: brancz/kube-rbac-proxy | ||
| tag: v0.21.0 | ||
| sha: "" |
There was a problem hiding this comment.
To align with the main image configuration and the suggested change in daemonset.yaml, this should be digest instead of sha.
digest: ""
github-actions
bot
force-pushed
the
upgrade/prometheus-node-exporter/4.52.0
branch
from
d02c842 to
c912ba1
Compare
…4.52.0 Signed-off-by: robot <robot@example.com>
github-actions
bot
force-pushed
the
upgrade/prometheus-node-exporter/4.52.0
branch
from
c912ba1 to
bee9392
Compare
2 participants
I am robot, upgrade: project prometheus-node-exporter chart upgrade from 4.6.0 to 4.52.0