Robot Upgrade: submariner-k8s-broker chart upgrade from 0.19.2 to 0.23.1

[weizhoublue]

I am robot, upgrade: project submariner-k8s-broker chart upgrade from 0.19.2 to 0.23.1

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant upgrade of the submariner-k8s-broker Helm chart to version 0.23.1. The upgrade involves updating the chart's version metadata, revising the Custom Resource Definitions to align with newer API specifications, and streamlining the Helm templating for RBAC and service account management. These changes ensure compatibility with the latest Submariner components and simplify the chart's configuration.

Highlights

• Chart Version Upgrade: The submariner-k8s-broker Helm chart has been upgraded from version 0.19.2 to 0.23.1, reflecting updated dependencies and features.
• Custom Resource Definition (CRD) Updates: Significant changes were applied to the CRD schemas for Cluster, Endpoint, ServiceExport, and ServiceImport, including reordering, new fields, and updated validation rules to align with the latest API specifications.
• Helm Template Refactoring: The Helm templates for RBAC and Service Account creation were refactored, simplifying the logic and introducing a dedicated template for the broker role definition.
• Configuration Simplification: Configuration options for rbac, crd, and serviceAccounts were removed from values.yaml files, and the 'Values' section was removed from README.md files, indicating a streamlined approach to chart configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• charts/submariner-k8s-broker/config
  • Updated the VERSION export from 0.19.2 to 0.23.1.
• charts/submariner-k8s-broker/submariner-k8s-broker/Chart.yaml
  • Updated appVersion, version, and dependencies.version to 0.23.1.
• charts/submariner-k8s-broker/submariner-k8s-broker/README.md
  • Removed the 'Values' section.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/Chart.yaml
  • Updated appVersion and version to 0.23.1.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/README.md
  • Removed the 'Values' section.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/crds/crd.yaml
  • Reordered and updated the CustomResourceDefinition for clusters.submariner.io and endpoints.submariner.io.
  • Added controller-gen.kubebuilder.io/version: v0.20.0 annotations to CRDs.
  • Introduced maxLength and minLength for cluster_id in Endpoint and Cluster CRDs.
  • Added healthCheckIPs, privateIPs, and publicIPs fields with maxItems: 2 and deprecation descriptions to the Endpoint CRD.
  • Removed private_ip and public_ip from the required fields in Endpoint CRD.
  • Updated descriptions for apiVersion and kind fields in CRDs.
  • Replaced latency with latencyRTT in Gateway CRD, updating its description and properties.
  • Added usingIP and usingNAT fields to Gateway status.
  • Updated ServiceExport CRD to include spec with exportedAnnotations and exportedLabels, and refined status.conditions schema with more detailed descriptions and validation patterns.
  • Added svcexport to ServiceExport short names.
  • Updated ServiceImport CRD to allow maxItems: 2 for ips and added a default: TCP for protocol in ports.
  • Added svcimport to ServiceImport short names.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/templates/_helpers.tpl
  • Simplified the clientServiceAccountName definition by removing conditional logic.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/templates/_role.tpl
  • Added a new template defining the broker-role with permissions for submariner.io, multicluster.x-k8s.io, discovery.k8s.io, and core Kubernetes resources.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/templates/rbac.yaml
  • Refactored RBAC definition to include the broker-role template and removed the conditional rbac.create check.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/templates/svc-acct.yaml
  • Removed the conditional serviceAccounts.client.create check.
• charts/submariner-k8s-broker/submariner-k8s-broker/charts/submariner-k8s-broker/values.yaml
  • Removed rbac, crd, and serviceAccounts configuration entries.
• charts/submariner-k8s-broker/submariner-k8s-broker/values.yaml
  • Removed rbac, crd, and serviceAccounts configuration entries.

Activity

• The pull request was opened by a robot user, indicating an automated chart upgrade process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request automates the upgrade of the submariner-k8s-broker Helm chart from version 0.19.2 to 0.23.1. The changes are comprehensive, including updates to Custom Resource Definitions (CRDs) with new fields, deprecations, and improved validation. The Helm templates have been refactored for simplicity, removing previously configurable values from values.yaml. A notable improvement is in the RBAC rules, which are now more specific and adhere better to the principle of least privilege by removing wildcard permissions. The changes appear correct and align with the version upgrade. I have one minor suggestion to ensure file formatting conventions are met.

[gemini-code-assist]

It is a common convention and POSIX standard that text files should end with a newline character. This prevents potential issues with some command-line tools and improves file handling consistency.

{{- end -}}