Skip to content

Update azure-webapps-node.yml#8

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1
Jun 13, 2025
Merged

Update azure-webapps-node.yml#8
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jun 13, 2025

Summary by Sourcery

Update the Azure Web Apps Node deployment workflow to label the install-build-test step and enforce the presence of a package lock file.

CI:

  • Name the npm install/build/test step for clarity in the workflow
  • Add a validation step to error out if neither package-lock.json nor yarn.lock is present

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 13, 2025

Reviewer's Guide

This PR refines the Azure Web Apps Node CI workflow by labeling and grouping the install/build/test steps for clarity and adding a new step to enforce presence of a lock file before deployment.

Sequence Diagram for Modified Build Job Execution

sequenceDiagram
    participant BuildJob as "Build Job"

    BuildJob->>BuildJob: Setup Node.js
    BuildJob->>BuildJob: Perform 'npm install, build, and test'
    BuildJob->>BuildJob: Perform 'Check for lock file' (New Step)
    BuildJob->>BuildJob: Perform 'Upload artifact'
Loading

File-Level Changes

Change Details Files
Group npm install, build, and test into a single named step
  • Added a step name “npm install, build, and test”
  • Consolidated the three npm commands under one run block
.github/workflows/azure-webapps-node.yml
Introduce lock file validation step
  • Added a step name “Check for lock file”
  • Script checks for presence of package-lock.json or yarn.lock
  • Fails the workflow with an error message if no lock file is found
.github/workflows/azure-webapps-node.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

  • .github/workflows/azure-webapps-node.yml

@Dargon789 Dargon789 merged commit c29f13a into master Jun 13, 2025
4 of 6 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch June 13, 2025 17:57
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dargon789 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant