Add Sort Tabs Context Menu with Preference Toggle#40
Open
ninjaeon wants to merge 4 commits intoDarsh-A:mainfrom
Open
Add Sort Tabs Context Menu with Preference Toggle#40ninjaeon wants to merge 4 commits intoDarsh-A:mainfrom
ninjaeon wants to merge 4 commits intoDarsh-A:mainfrom
Conversation
- Added context_zenSortTabs menu item to tab context menu - Positioned before "Reload Tab" for logical grouping - Added separator for better visual separation - Smart visibility based on sort feature and workspace state - Hides when multiple tabs selected (use button instead) - Uses existing cmd_zenSortTabs command for consistency - Updated initialization to check for tabContextMenu availability 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land>
- Added "Enable the sort tabs context menu item" toggle under Feature Toggles - New preference key: extensions.tabgroups.enable_context_menu - Context menu item now respects this toggle preference - Added CSS media query to hide menu item when disabled - Updated CONFIG.featureConfig to include contextMenu setting - Only sets up context menu when the feature is enabled 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land>
- Added "restart": true to context menu preference - Sine will automatically show restart confirmation when toggling - Provides one-click restart functionality via toast notification - Improves user experience with clear feedback about required restart - Consistent with other Sine mod behavior 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Implementation Details
MozXULElement.parseXULToFragment()patterncmd_zenSortTabscommand💘 Generated with Crush CLI using GLM-4.6 to vibe code these features. Manual review is recommended as I'm not a programmer.