Skip to content

dts-subscription: error out if no password is provided #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xyhhx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dts-subscription: error out if no password is provided #125

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1521f0a
dts-subscription: error out if no password is provided
xyhhx Oct 18, 2025
98ad37f
dts-subscription: error out if no email is provided either
xyhhx Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/dts-subscription.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ get_dpp_creds() {
echo ""
read -p "Enter password: " 'DPP_PASSWORD'

if [[ -z "${DPP_PASSWORD}" ]]; then
Copy link
Contributor

@m-iwanicki m-iwanicki Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same problem happens when e-mail is empty, I forgot to mention it in issue.

Add another, separate check for e-mail just after entering it. That way E2E007.005 Check empty e-mail should not pass and E2E007.006 Check empty password should not pass should both pass

Copy link
Contributor

@m-iwanicki m-iwanicki Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you added 98ad37f, please move check between e-mail and password input:

  read -p "Enter DPP email: " 'DPP_EMAIL'
  echo ""

  if [[ -z "${DPP_EMAIL}" ]]; then
    print_error "No email address was provided."
    return 1
  fi

  read -p "Enter password:    " 'DPP_PASSWORD'

print_warning "No password was provided."
return 1
fi

# Export DPP creds to a file for future use. Currently these are being used
# for both: MinIO (and its mc CLI) and cloudsend (deprecated, all DPP
# sibscribtions will be megrated to MinIO):
Expand Down