Skip to content

Btg key validator test #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m-iwanicki merged 3 commits into from
Jan 14, 2026
Merged

Btg key validator test #1194

m-iwanicki merged 3 commits into from
Jan 14, 2026
+116 −0

Conversation

@m-iwanicki
Copy link
Contributor

@m-iwanicki m-iwanicki commented Jan 8, 2026 •
edited
Loading

Related to: Dasharo/dts-scripts#140

$ robot -b cmd_logs.txt -v rte_ip:127.0.0.1 -v config:qemu \
      -L TRACE -v boot_dts_from_ipxe_shell:True \
      -v dts_ipxe_link:http://192.168.4.48:4321/dts.ipxe \
      -v snipeit:no -v dts_config_ref:refs/heads/add-intel-btg-hash-test \
      -t "Create Tests" -t "E2E016.0*" dts/dts-e2e.robot
==============================================================================
Dts-E2E
==============================================================================
Create tests                                                          | PASS |
------------------------------------------------------------------------------
E2E016.001 Verify that btg_key_validator prints expected error on ... | PASS |
------------------------------------------------------------------------------
E2E016.002 Verify that btg_key_validator prints expected error on ... | PASS |
------------------------------------------------------------------------------
E2E016.003 Verify that btg_key_validator prints expected error on ... | PASS |
------------------------------------------------------------------------------
E2E016.004 Verify that btg_key_validator prints expected error if ... | PASS |
------------------------------------------------------------------------------
E2E016.005 Verify that btg_key_validator prints expected message i... | PASS |
------------------------------------------------------------------------------
E2E016.006 Verify that fuse workflow uses and verifies btg_key_val... | PASS |
------------------------------------------------------------------------------
E2E001: novacustom-v540tu Fuse Platform - DCR                         | PASS |
------------------------------------------------------------------------------
E2E002: novacustom-v560tu Fuse Platform - DCR                         | PASS |
------------------------------------------------------------------------------
Dts-E2E                                                               | PASS |
==============================================================================

@m-iwanicki
lib: terminal: Add Execute Command keyword that returns output & rc
66cd84b 
Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
@m-iwanicki m-iwanicki self-assigned this Jan 8, 2026
@m-iwanicki m-iwanicki mentioned this pull request Jan 8, 2026
Merged
@m-iwanicki
dts: profiles: Add btg_key_validator
5e4543b 
Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
@m-iwanicki
dts: e2e: Add btg_key_validator and fuse workflow tests
58c0cc2 
Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
@m-iwanicki m-iwanicki force-pushed the btg_key_validator_test branch from cccdfe3 to 58c0cc2 Compare January 9, 2026 10:45
3mkusiak
3mkusiak approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@3mkusiak 3mkusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM.

I've run full E2E test set and all tests that did not require access to pre-release/hidden binaries passed. The tests that required custom FW server didn't pass which is expected. I've been reproducing this manually in the past successfully, so I trust you the tests are working as well.

The other note is that you should probably rebase dts-scripts branch on top of newest main and rerun full test set. The issue is, your feature branch does not feature changes for fd sheduling therefore many tests fail due to profile mismatch. Please do so before merging.

@m-iwanicki
Copy link
Contributor Author

m-iwanicki commented Jan 14, 2026

@3mkusiak

Tested with dts-configs add-intel-btg-hash-test branch and rebased dts-scripts PR. The only failures are credential tests.

Log: 

==============================================================================
Dts-E2E
==============================================================================
Create tests                                                          | PASS |
------------------------------------------------------------------------------
E2E001.001 HCL Report test :: Verify that HCL Report is being exec... | PASS |
------------------------------------------------------------------------------
E2E002.001 DCR Initial Deployment On Msi-pro-z690-a-ddr5 With 13th... | PASS |
------------------------------------------------------------------------------
E2E002.002 DCR Initial Deployment On Msi-pro-z690-a-wifi-ddr4 With... | PASS |
------------------------------------------------------------------------------
E2E003.001 DCR UEFI Update On Msi-pro-z690-a-ddr5 With 13th Gen CP... | PASS |
------------------------------------------------------------------------------
E2E003.002 DCR UEFI Update On Msi-pro-z690-a-wifi-ddr4 With 13th G... | PASS |
------------------------------------------------------------------------------
E2E007.001 Check credentials are being saved correctly :: Check th... | PASS |
------------------------------------------------------------------------------
E2E007.002 Check old credentials are being overwritten by new :: M... | FAIL |
------------------------------------------------------------------------------
E2E007.003 Check wrong credentials should not allow to log into DP... | FAIL |
------------------------------------------------------------------------------
E2E007.004 Check correct credentials should allow to log into DPP ... | PASS |
------------------------------------------------------------------------------
E2E007.005 Check empty e-mail should not pass :: Entering empty e-... | FAIL |
------------------------------------------------------------------------------
E2E007.006 Check empty password should not pass :: Entering empty ... | FAIL |
------------------------------------------------------------------------------
E2E007.008 Check DPP credentials with access to only firmware :: T... | PASS |
------------------------------------------------------------------------------
E2E007.009 Check DPP credentials with access to only extensions ::... | FAIL |
------------------------------------------------------------------------------
E2E007.010 Check DPP credentials without DPP access :: Those crede... | PASS |
------------------------------------------------------------------------------
E2E007.011 Check DPP credentials with both DPP firmware and DTS ex... | PASS |
------------------------------------------------------------------------------
E2E008.001 Reboot UI Option Calls Reboot Command :: Reboot (R) UI ... | PASS |
------------------------------------------------------------------------------
E2E008.002 Poweroff UI Option Calls Poweroff Command :: Poweroff (... | PASS |
------------------------------------------------------------------------------
E2E008.003 Launch SSH Server UI Option Enables SSH Server Command ... | PASS |
------------------------------------------------------------------------------
E2E008.004 Enable Sending Logs UI Option Should Enable DTS Log Sen... | PASS |
------------------------------------------------------------------------------
E2E009.001 DTS extensions are installed and can be used :: Test th... | PASS |
------------------------------------------------------------------------------
E2E010.001 Failure to read flash during update should stop workflo... | PASS |
------------------------------------------------------------------------------
E2E011.001 Aborting update after smmstore migration failure should... | PASS |
------------------------------------------------------------------------------
E2E012.001 Continuing update after smmstore migration failure shou... | PASS |
------------------------------------------------------------------------------
E2E013.001 Verify that FUM update doesn't start automatically :: T... | PASS |
------------------------------------------------------------------------------
E2E014.001 Verify that FUM update succeeds :: Test that FUM update... | PASS |
------------------------------------------------------------------------------
E2E015.001 Verify that entering DTS menu in FUM works :: Test that... | PASS |
------------------------------------------------------------------------------
E2E016.001 Verify that btg_key_validator prints expected error on ... | PASS |
------------------------------------------------------------------------------
E2E016.002 Verify that btg_key_validator prints expected error on ... | PASS |
------------------------------------------------------------------------------
E2E016.003 Verify that btg_key_validator prints expected error on ... | PASS |
------------------------------------------------------------------------------
E2E016.004 Verify that btg_key_validator prints expected error if ... | PASS |
------------------------------------------------------------------------------
E2E016.005 Verify that btg_key_validator prints expected message i... | PASS |
------------------------------------------------------------------------------
E2E016.006 Verify that fuse workflow uses and verifies btg_key_val... | PASS |
------------------------------------------------------------------------------
E2E001: optiplex-7010 Initial Deployment - DPP                        | PASS |
------------------------------------------------------------------------------
E2E002: optiplex-7010 UEFI Update - DPP                               | PASS |
------------------------------------------------------------------------------
E2E003: optiplex-9010 Initial Deployment - DPP                        | PASS |
------------------------------------------------------------------------------
E2E004: optiplex-9010 UEFI Update - DPP                               | PASS |
------------------------------------------------------------------------------
E2E005: novacustom-nuc_box-125H Initial Deployment - DCR              | PASS |
------------------------------------------------------------------------------
E2E006: novacustom-nuc_box-155H Initial Deployment - DCR              | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E007: novacustom-ns50mu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E008: novacustom-ns50mu UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E009: novacustom-ns50pu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E010: novacustom-ns50pu UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E011: novacustom-ns70mu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E012: novacustom-ns70mu UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E013: novacustom-ns70pu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E014: novacustom-ns70pu UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E015: novacustom-nv41mb Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E016: novacustom-nv41mb UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E017: novacustom-nv41mz Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E018: novacustom-nv41mz UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E019: novacustom-nv41pz Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E020: novacustom-nv41pz UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
E2E021: novacustom-nv41pz UEFI->Heads Transition - DPP                | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E022: novacustom-v560tne Initial Deployment - DCR                   | PASS |
------------------------------------------------------------------------------
E2E023: novacustom-v560tne UEFI Update - DCR                          | PASS |
------------------------------------------------------------------------------
E2E024: odroid-h4-plus Initial Deployment - DPP                       | PASS |
------------------------------------------------------------------------------
E2E025: odroid-h4-plus UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E026: odroid-h4-plus Dasharo (coreboot+UEFI) to Dasharo (Slim Bo... | PASS |
------------------------------------------------------------------------------
E2E027: odroid-h4-plus Dasharo (Slim Bootloader+UEFI) Initial Depl... | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E028: novacustom-v540tnd Initial Deployment - DCR                   | PASS |
------------------------------------------------------------------------------
E2E029: novacustom-v540tnd UEFI Update - DCR                          | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E030: novacustom-v540tu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E031: novacustom-v540tu UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
E2E032: novacustom-v540tu UEFI->Heads Transition - DPP                | PASS |
------------------------------------------------------------------------------
E2E033: novacustom-v540tu Fuse Platform - DCR                         | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E034: novacustom-v560tnd Initial Deployment - DCR                   | PASS |
------------------------------------------------------------------------------
E2E035: novacustom-v560tnd UEFI Update - DCR                          | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E036: novacustom-v560tu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E037: novacustom-v560tu UEFI Update - DCR                           | PASS |
------------------------------------------------------------------------------
E2E038: novacustom-v560tu UEFI->Heads Transition - DPP                | PASS |
------------------------------------------------------------------------------
E2E039: novacustom-v560tu Fuse Platform - DCR                         | PASS |
------------------------------------------------------------------------------
E2E040: pcengines-apu2 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E041: pcengines-apu2 SeaBIOS Update - DPP                           | PASS |
------------------------------------------------------------------------------
E2E042: pcengines-apu2 SeaBIOS->UEFI Transition - DPP                 | PASS |
------------------------------------------------------------------------------
E2E043: pcengines-apu3 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E044: pcengines-apu3 SeaBIOS Update - DPP                           | PASS |
------------------------------------------------------------------------------
E2E045: pcengines-apu3 SeaBIOS->UEFI Transition - DPP                 | PASS |
------------------------------------------------------------------------------
E2E046: pcengines-apu4 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E047: pcengines-apu4 SeaBIOS Update - DPP                           | PASS |
------------------------------------------------------------------------------
E2E048: pcengines-apu4 SeaBIOS->UEFI Transition - DPP                 | PASS |
------------------------------------------------------------------------------
E2E049: pcengines-apu6 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E050: pcengines-apu6 SeaBIOS Update - DPP                           | PASS |
------------------------------------------------------------------------------
E2E051: pcengines-apu6 SeaBIOS->UEFI Transition - DPP                 | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E052: msi-pro-z690-a-ddr5 Initial Deployment - DCR                  | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E053: msi-pro-z690-a-ddr5 Initial Deployment - DPP                  | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E054: msi-pro-z690-a-ddr5 UEFI Update - DCR                         | PASS |
------------------------------------------------------------------------------
E2E055: msi-pro-z690-a-ddr5 UEFI Update - DPP                         | PASS |
------------------------------------------------------------------------------
E2E056: msi-pro-z690-a-wifi-ddr4 Initial Deployment - DCR             | PASS |
------------------------------------------------------------------------------
E2E057: msi-pro-z690-a-wifi-ddr4 Initial Deployment - DPP             | PASS |
------------------------------------------------------------------------------
E2E058: msi-pro-z690-a-wifi-ddr4 UEFI Update - DCR                    | PASS |
------------------------------------------------------------------------------
E2E059: msi-pro-z690-a-wifi-ddr4 UEFI Update - DPP                    | PASS |
------------------------------------------------------------------------------
E2E060: msi-pro-z790-p-ddr5 Initial Deployment - DPP                  | PASS |
------------------------------------------------------------------------------
E2E061: msi-pro-z790-p-ddr5 UEFI Update - DPP                         | PASS |
------------------------------------------------------------------------------
Dts-E2E                                                               | FAIL |
94 tests, 89 passed, 5 failed
==============================================================================

@m-iwanicki m-iwanicki merged commit 58c0cc2 into develop Jan 14, 2026
2 checks passed
@m-iwanicki m-iwanicki deleted the btg_key_validator_test branch January 14, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3mkusiak 3mkusiak 3mkusiak approved these changes

@DaniilKl DaniilKl Awaiting requested review from DaniilKl

Assignees

@m-iwanicki m-iwanicki

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m-iwanicki @3mkusiak