Add Azul GitHub project and priority support to schedule.py (#7474, #7548) #7622

achave11-ucsc · 2025-12-08T18:29:32Z

Linked issues: #7474, #7548

Note

It is likely that the system administrator will require increasing the scope of the token used by the action invoking schedule.py to fully include project scope

Checklist

Author

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all linked issues}
This PR partially resolves each of the linked issues _{or does not have the partial label}

Author (reindex)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}

Author (API changes)

This PR and its linked issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any linked issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues linked to this PR}

Author (before every review)

Rebased PR branch on develop, squashed fixups from prior reviews
Ran make requirements_update _{or this PR does not modify Dockerfile, environment, requirements*.txt, common.mk, Makefile or environment.boot}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}
PR is awaiting requested review from a peer
Status of PR is Review requested
PR is assigned to only the peer and the author

Peer reviewer (after approval)

Note that after requesting changes, the PR must be assigned to only the author.

Actually approved the PR
PR is not a draft
PR is awaiting requested review from system administrator
Status of PR is Review requested
PR is assigned to only the system administrator and the author

System administrator (after approval)

Actually approved the PR
Labeled linked issues as demo or no demo
Commented on linked issues about demo expectations _{or all linked issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Status of PR is Approved
PR is assigned to only the operator and the author

Operator

Checked reindex:… labels and r commit title tag
Checked that demo expectations are clear _{or all linked issues are labeled no demo}
Squashed PR branch and rebased onto develop
Sanity-checked history
Pushed PR branch to GitHub

Operator (deploy `.shared` and `.gitlab` components)

Ran _select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Ran _select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Checked the items in the next section _{or this PR is labeled deploy:gitlab}
PR is assigned to only the system administrator and the author _{or this PR is not labeled deploy:gitlab}

System administrator (post-deploy of `.gitlab` component)

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator and the author

Operator (deploy runner image)

Ran _select dev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
Ran _select anvildev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}

Operator (sandbox build)

Operator (merge the branch)

All status checks passed and the PR is mergeable
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but only included p if the PR is also labeled partial}
Pushed merge commit to GitHub
Status of PR is Merged lower
Status of blocked issues is Triage _{or no issues are blocked on the linked issues}
Requested from PR author that the last remaining CL item in Remove priority labels #7474 (comment) be completed
PR author confirmed full completion of CL items in Remove priority labels #7474

Operator (main build)

Operator (reindex)

Operator (mirroring)

Started mirroring in dev _{or this PR does not require mirroring dev}
Started mirroring in anvildev _{or this PR does not require mirroring anvildev}
Checked for, triaged and possibly requeued messages in mirror fail queue in dev _{or this PR does not require mirroring dev}
Checked for, triaged and possibly requeued messages in mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}
Emptied mirror fail queue in dev _{or this PR does not require mirroring dev}
Emptied mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

nadove-ucsc · 2025-12-11T23:18:47Z

.github/workflows/schedule.py

+                    url
+                ]
+                log.info('Running %r …', command)
+                process = subprocess.run(command, check=True, stdout=subprocess.PIPE)


False positive, the variable is used on the next line

coveralls · 2025-12-08T18:44:37Z

coverage: 85.066%. remained the same
when pulling 45026ef on issues/achave11-ucsc/7474-remove-priority-labels
into 579ad14 on develop.

codecov · 2025-12-08T18:45:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (579ad14) to head (45026ef).
⚠️ Report is 71 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7622   +/-   ##
========================================
  Coverage    84.84%   84.84%           
========================================
  Files          157      157           
  Lines        22871    22871           
========================================
  Hits         19405    19405           
  Misses        3466     3466

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

achave11-ucsc · 2025-12-10T03:17:06Z

Title differs from the issue because the PR addresses two issues.

nadove-ucsc · 2025-12-11T02:14:05Z

.github/workflows/schedule.py

-                log.info('Successfully created and verfied issue #%s', issue_number)
+                self.verify_issue(assignees, issue, labels, repository, type, url)
+
+    def verify_issue(self, assignees, issue, labels, repository, type, url):


Type annotations would be nice here

What's the point of this change? The PR doesn't add any other call sites.

What's the point of this change?

To encapsulate the verification logic, but is not as extensive as I originally thought so I've dropped this change.

The PR doesn't add any other call sites.

Respectfully, is that a requirement?

No, it isn't a requirement. It's the most obvious reason for extracting a method, but there are other valid reasons, including encapsulation. If you had decided to keep the change, I would have accepted your rationale.

nadove-ucsc · 2025-12-11T02:17:49Z

.github/workflows/schedule.py

+        assert set(labels) <= actual_labels, (labels, actual_labels)
+        actual_type = issue['type']['name']
+        assert type == actual_type, (type, actual_type)
+        log.info('Successfully created and verfied issue #%s', issue_number)


Typo in "verfied". Fix in a separate commit.

nadove-ucsc · 2025-12-11T02:24:41Z

.github/workflows/schedule.py

+                assert issue_project['title'] == issue['title'], issue_project['title']
+                assert issue_project['url'] == url, issue_project['url']
+                assert issue_project['id'] == project['id'], issue_project['id']


Suggested change

assert issue_project['title'] == issue['title'], issue_project['title']

assert issue_project['url'] == url, issue_project['url']

assert issue_project['id'] == project['id'], issue_project['id']

assert issue_project['title'] == issue['title'], (issue_project['title'], issue['title'])

assert issue_project['url'] == url, (issue_project['url'], url)

assert issue_project['id'] == project['id'], (issue_project['id'], project['id'])

nadove-ucsc · 2025-12-11T23:22:20Z

.github/workflows/schedule.py

+                process = subprocess.run(command, check=True, stdout=subprocess.PIPE)
+                item = json.loads(process.stdout)
+                assert item['id'], item
+                priority = self.properties.get('_project_item_priority')


I think using .get is a bad idea here, because if priority is None then line 241 will raise a KeyError.

Suggested change

priority = self.properties.get('_project_item_priority')

priority = self.properties['_project_item_priority']

nadove-ucsc · 2025-12-11T23:25:49Z

.github/workflows/schedule.py

+                project = json.loads(process.stdout)
+                assert project['title'] == title, (project['title'], title)
+                assert project['url'] == url, (project['url'], url)
+                assert project['id'] == item['id'], (project['id'], item['id'])


There are three separate lookups of item['id'], so maybe extract a local for it?

nadove-ucsc · 2025-12-11T23:31:05Z

.github/workflows/schedule.py

-                log.info('Successfully created and verfied issue #%s', issue_number)
+                self.verify_issue(assignees, issue, labels, repository, type, url)
+
+    def verify_issue(self, assignees, issue, labels, repository, type, url):


No, it isn't a requirement. It's the most obvious reason for extracting a method, but there are other valid reasons, including encapsulation. If you had decided to keep the change, I would have accepted your rationale.

hannes-ucsc · 2025-12-12T17:53:18Z

.github/workflows/schedule.py



+azul_project_number = '3'
+azul_project_id = 'PVT_kwDOAfSQ384BCJY8'


I don't remember agreeing that it would be OK to hard-code all this

$ gh project list --format json --owner DataBiosphere --jq '.projects[]|select(.title == "Azul")|.number' 3 $ gh project field-list 3 --owner=DataBiosphere --format=json --jq '.fields[]|select(.name == "Priority")|.options' [ { "id": "bdf99630", "name": "++" }, { "id": "3333032d", "name": "+" }, { "id": "5e2e7b47", "name": "-" }, { "id": "b903d2dc", "name": "--" } ]

You can probably extract the owner from the environment. The only thing you'd have to hard-code is the project and field name.

…le.py

…l project (#7548)

#7474)

hannes-ucsc · 2026-01-06T17:41:44Z

.github/workflows/schedule.py

-                '-f', f'body={self.body}',
-                '-f', f'type={type}'
-            ]
+            command = list()


Suggested change

command = list()

command = []

hannes-ucsc · 2026-01-06T17:43:57Z

.github/workflows/schedule.py

            for label in labels:
                command.extend(['-f', f'labels[]={label}'])
            if self.dry_run:
                log.info('Would run %r', command)


This just logs a fragment of the command, which isn't helpful.

hannes-ucsc · 2026-01-06T19:07:56Z

.github/workflows/schedule.py

+                ])
+                priority_ids = {pf['name']: pf['id'] for pf in priority_field['options']}
+                priority = self.properties['_project_item_priority']
+                project = self.gh_json([


I think this variable holds an item, not a project.

achave11-ucsc

'Monthly web app vulnerability scans' ticket is missing operator label.

github-advanced-security bot found potential problems Dec 8, 2025

View reviewed changes

achave11-ucsc self-assigned this Dec 8, 2025

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch from ed9db65 to 8f71a70 Compare December 9, 2025 19:22

This was linked to issues Dec 9, 2025

Scheduled azul-private issues are not automatically added to Azul project #7548

Open

Remove priority labels #7474

Open

achave11-ucsc changed the title ~~Fix: Remove priority labels (#7474)~~ Fix: Remove priority labels (#7474, #7548) Dec 9, 2025

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch 2 times, most recently from 9fbbec1 to 0938b89 Compare December 10, 2025 03:13

achave11-ucsc changed the title ~~Fix: Remove priority labels (#7474, #7548)~~ Enhancements to schedule.py (#7474, #7548) Dec 10, 2025

achave11-ucsc changed the title ~~Enhancements to schedule.py (#7474, #7548)~~ Add Azul GitHub project and priority support to schedule.py (#7474, #7548) Dec 10, 2025

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch 2 times, most recently from 31cdffc to 6ac3db6 Compare December 10, 2025 18:26

achave11-ucsc assigned nadove-ucsc Dec 10, 2025

achave11-ucsc requested a review from nadove-ucsc December 10, 2025 19:01

achave11-ucsc unassigned nadove-ucsc Dec 10, 2025

achave11-ucsc removed the request for review from nadove-ucsc December 10, 2025 22:22

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch from 4d95c72 to 0cf4188 Compare December 10, 2025 22:26

achave11-ucsc assigned nadove-ucsc Dec 10, 2025

achave11-ucsc requested a review from nadove-ucsc December 10, 2025 22:43

nadove-ucsc requested changes Dec 11, 2025

View reviewed changes

nadove-ucsc removed their assignment Dec 11, 2025

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch from 7443e1e to a0961b9 Compare December 11, 2025 18:39

achave11-ucsc requested a review from nadove-ucsc December 11, 2025 19:32

achave11-ucsc assigned nadove-ucsc Dec 11, 2025

nadove-ucsc requested changes Dec 11, 2025

View reviewed changes

nadove-ucsc removed their assignment Dec 11, 2025

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch from a0961b9 to d1a5c69 Compare December 12, 2025 05:24

nadove-ucsc previously approved these changes Dec 12, 2025

View reviewed changes

nadove-ucsc marked this pull request as ready for review December 12, 2025 08:11

nadove-ucsc requested a review from hannes-ucsc as a code owner December 12, 2025 08:11

nadove-ucsc assigned hannes-ucsc and unassigned nadove-ucsc Dec 12, 2025

hannes-ucsc requested changes Dec 12, 2025

View reviewed changes

hannes-ucsc added the 1 review [process] Lead requested changes once label Dec 12, 2025

hannes-ucsc removed their assignment Dec 12, 2025

Fix typo in schedule.py logging message

e1858f4

achave11-ucsc dismissed nadove-ucsc’s stale review via e1858f4 December 24, 2025 04:50

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch 6 times, most recently from f694245 to 8de92d8 Compare December 24, 2025 05:57

achave11-ucsc added 6 commits December 23, 2025 22:00

Refactor command execution logging and output serialization in schedu…

e09f602

…le.py

Fix: Scheduled azul-private issues are not automatically added to Azu…

a68d525

…l project (#7548)

Add project item priority support to schedule.py (#7474)

5dff9cc

fixup! Add project item priority support to schedule.py (#7474)

cb887d9

Add project_item_priority to front matter template in scheduled issues (

4d9267e

#7474)

Remove priority labels from scheduled issue templates (#7474)

45026ef

achave11-ucsc force-pushed the issues/achave11-ucsc/7474-remove-priority-labels branch from 87d2bec to e09f602 Compare December 24, 2025 06:00

achave11-ucsc requested a review from hannes-ucsc December 24, 2025 06:24

achave11-ucsc assigned hannes-ucsc Dec 24, 2025

hannes-ucsc requested changes Jan 6, 2026

View reviewed changes

hannes-ucsc added 2 reviews [process] Lead requested changes twice and removed 1 review [process] Lead requested changes once labels Jan 6, 2026

hannes-ucsc removed their assignment Jan 6, 2026

achave11-ucsc commented Jan 6, 2026

View reviewed changes

	priority = self.properties.get('_project_item_priority')
	priority = self.properties['_project_item_priority']



		azul_project_number = '3'
		azul_project_id = 'PVT_kwDOAfSQ384BCJY8'

Add Azul GitHub project and priority support to schedule.py (#7474, #7548) #7622

Are you sure you want to change the base?

Add Azul GitHub project and priority support to schedule.py (#7474, #7548) #7622

Uh oh!

Conversation

achave11-ucsc commented Dec 8, 2025 • edited by nadove-ucsc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note

Checklist

Author

Author (partiality)

Author (reindex)

Author (API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator

Operator (deploy .shared and .gitlab components)

System administrator (post-deploy of .gitlab component)

Operator (deploy runner image)

Operator (sandbox build)

Operator (merge the branch)

Operator (main build)

Operator (reindex)

Operator (mirroring)

Operator

Shorthand for review comments

Uh oh!

Check notice

Choose a reason for hiding this comment

Uh oh!

coveralls commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

achave11-ucsc commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

achave11-ucsc Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

achave11-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

achave11-ucsc commented Dec 8, 2025 •

edited by nadove-ucsc

Loading

Operator (deploy `.shared` and `.gitlab` components)

System administrator (post-deploy of `.gitlab` component)

coveralls commented Dec 8, 2025 •

edited

Loading

codecov bot commented Dec 8, 2025 •

edited

Loading

achave11-ucsc Dec 11, 2025 •

edited

Loading

hannes-ucsc Dec 12, 2025 •

edited

Loading