Skip to content

Conversation

@fboulnois
Copy link
Contributor

Addresses

Summary

Adds feature flags to Consent. The API is:

  • GET /api/feature - List all feature flags (unauthenticated)
  • GET /api/feature/id - Get a specific flag (unauthenticated)
  • POST /api/feature/id - Create/update value (admin-only), body: {"value": "..."}
  • DELETE /api/feature/id - Delete a feature flag (admin-only)

Some helper methods exist that consent itself can use to determine if a feature flag is enabled. I kept the value as a string, as we may want multiple states beyond enabled or disabled.

Unit tests cover all functionality.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner January 22, 2026 20:31
@fboulnois fboulnois requested review from otchet-broad and rushtong and removed request for a team January 22, 2026 20:31
@fboulnois fboulnois force-pushed the fb-dt-2824-feature-flags branch from 97f6c8c to 5616735 Compare January 22, 2026 20:37
@fboulnois fboulnois marked this pull request as draft January 22, 2026 20:40
@fboulnois fboulnois force-pushed the fb-dt-2824-feature-flags branch 2 times, most recently from 108e3dd to 57008dc Compare January 22, 2026 20:54
@fboulnois fboulnois marked this pull request as ready for review January 23, 2026 15:37
@fboulnois fboulnois force-pushed the fb-dt-2824-feature-flags branch from 3a4ba79 to eb05a75 Compare January 23, 2026 16:05
@fboulnois fboulnois force-pushed the fb-dt-2824-feature-flags branch from eb05a75 to 716717f Compare January 23, 2026 16:11
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you 👍🏽

Copy link
Contributor

@otchet-broad otchet-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god!
One small item: I think we might want to add some audit logging for adding/removing feature flags so we can track who turned them on or off in a specific environment.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants