-
Notifications
You must be signed in to change notification settings - Fork 2
[DT-2824] Feature flags #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[DT-2824] Feature flags #2786
Conversation
97f6c8c to
5616735
Compare
108e3dd to
57008dc
Compare
src/main/java/org/broadinstitute/consent/http/resources/FeatureFlagResource.java
Outdated
Show resolved
Hide resolved
src/test/java/org/broadinstitute/consent/http/db/FeatureFlagDAOTest.java
Outdated
Show resolved
Hide resolved
3a4ba79 to
eb05a75
Compare
eb05a75 to
716717f
Compare
rushtong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you 👍🏽
src/main/java/org/broadinstitute/consent/http/service/FeatureFlagService.java
Outdated
Show resolved
Hide resolved
otchet-broad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks god!
One small item: I think we might want to add some audit logging for adding/removing feature flags so we can track who turned them on or off in a specific environment.
|



Addresses
Summary
Adds feature flags to Consent. The API is:
GET /api/feature- List all feature flags (unauthenticated)GET /api/feature/id- Get a specific flag (unauthenticated)POST /api/feature/id- Create/update value (admin-only), body:{"value": "..."}DELETE /api/feature/id- Delete a feature flag (admin-only)Some helper methods exist that consent itself can use to determine if a feature flag is enabled. I kept the
valueas a string, as we may want multiple states beyond enabled or disabled.Unit tests cover all functionality.
Have you read CONTRIBUTING.md lately? If not, do that first.