Skip to content

[DT-1501] Remove NIH Intramural designation in DAR given RAS update#2825

Merged
rjohanek merged 6 commits intodevelopfrom
rj-dt-1501-rm-check-collaborators
Apr 14, 2025
Merged

[DT-1501] Remove NIH Intramural designation in DAR given RAS update#2825
rjohanek merged 6 commits intodevelopfrom
rj-dt-1501-rm-check-collaborators

Conversation

@rjohanek
Copy link
Contributor

@rjohanek rjohanek commented Apr 11, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-1501
Check collaborator provides a loophole to avoid RAS authentication, we don't want that anymore.

Summary

Remove Check Collaborator/collaboration fields from the DAR application page and remove conditional logic that allowed bypassing RAS authentication.

Testing

Manually tested that you can still submit a DAR application and load old DARs.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rjohanek rjohanek requested a review from a team as a code owner April 11, 2025 16:07
@rjohanek rjohanek requested review from fboulnois and snf2ye and removed request for a team April 11, 2025 16:07
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you! 👍

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@rjohanek rjohanek merged commit 657c445 into develop Apr 14, 2025
10 checks passed
@rjohanek rjohanek deleted the rj-dt-1501-rm-check-collaborators branch April 14, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants