[DT-1501] Remove NIH Intramural designation in DAR given RAS update#2825
Merged
[DT-1501] Remove NIH Intramural designation in DAR given RAS update#2825
Conversation
fboulnois
approved these changes
Apr 14, 2025
Contributor
fboulnois
left a comment
There was a problem hiding this comment.
looks good, thank you! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1501
Check collaborator provides a loophole to avoid RAS authentication, we don't want that anymore.
Summary
Remove Check Collaborator/collaboration fields from the DAR application page and remove conditional logic that allowed bypassing RAS authentication.
Testing
Manually tested that you can still submit a DAR application and load old DARs.
Have you read Terra's Contributing Guide lately? If not, do that first.