[DT-1329] Enable RAS in production #3039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
force-pushed
the
fb-dt-1329-enable-ras
branch
from
88d0148 to
a423e38
Compare
fboulnois
commented
Sep 12, 2025
| }) | ||
| }) | ||
|
|
||
| describe('Test environment-disabled cases', () => { |
There was a problem hiding this comment.
RAS is enabled in all environments, so these tests no longer make sense.
fboulnois
commented
Sep 12, 2025
| mount(<ResearcherStatus user={userWithCard} pageProps={pageProps} />) | ||
| cy.contains('Researcher Status') | ||
| cy.contains('eRA Commons Account') | ||
| cy.contains('RAS Account') |
There was a problem hiding this comment.
Profile page will always point to RAS account
fboulnois
commented
Sep 12, 2025
| import StackdriverReporter from 'src/libs/stackdriverReporter' | ||
| import { Config } from 'src/libs/config' | ||
| import { MemoryRouter, Route } from 'react-router-dom' | ||
| import { MemoryRouter, Route, Router } from 'react-router-dom' |
There was a problem hiding this comment.
Router should be imported from react-router-dom in v5
fboulnois
commented
Sep 12, 2025
| @@ -96,7 +96,8 @@ export default function ERACommons(props) { | |||
| window.location.href = await AuthenticateNIH.getECMProviderAuthUrl(origin, redirectTo) | |||
| } | |||
| catch (error) { | |||
| const errorMessage = 'Error from Authentication Provider: ' + error?.response?.data?.message + ': ' + currentUser.email | |||
| const userEmail = currentUser?.email || 'unknown user' | |||
There was a problem hiding this comment.
It is possible that the email is empty in tests.
fboulnois
commented
Sep 12, 2025
| list: processVoteHistoryRowData(voteHistory), | ||
| sort, | ||
| })) | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
This was referenced Sep 12, 2025
fboulnois
requested review from
rushtong and
kevinmarete
and removed request for
a team
rushtong
approved these changes
Sep 12, 2025
fboulnois
changed the title
fboulnois
added
the
RAS
fboulnois
changed the title
fboulnois
force-pushed
the
fb-dt-1329-enable-ras
branch
from
a423e38 to
d1374e4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
DO NOT MERGE UNTIL 2025-09-29. Requires DataBiosphere/consent#2647 to be merged first.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1329
Summary
Enables RAS in production. The cleanup for this code is explicitly called out in DT-2116.
Have you read Terra's Contributing Guide lately? If not, do that first.