-
Notifications
You must be signed in to change notification settings - Fork 4
DT-2809: Update banner styling #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,33 @@ | |||
| .banner { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps consider migrating the CookieBanner to Material UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear on this suggestion. We are using some Material UI features in the component - are there additional things we can do here?
fboulnois
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few suggestions.
@fboulnois - this isn't approved by product yet - we're still in active conversations. |
otchet-broad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good!
fboulnois
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as resolved.
This comment was marked as resolved.
|
|
@fboulnois @kevinmarete @otchet-broad - PTAL, this version of the design has product approval. |




Addresses
https://broadworkbench.atlassian.net/browse/DT-2809
Summary
Per conversations with product, new colors and styling for the cookie banner as follows:
Screen widths >= 800px
Footer in view when scrolled
Screen widths < 800px
Have you read Terra's Contributing Guide lately? If not, do that first.