Skip to content

Conversation

@rushtong
Copy link
Contributor

@rushtong rushtong commented Jan 21, 2026

Addresses

https://broadworkbench.atlassian.net/browse/DT-2809

Summary

Per conversations with product, new colors and styling for the cookie banner as follows:

Screen widths >= 800px

Screenshot 2026-01-28 at 8 35 52 AM

Footer in view when scrolled

Screenshot 2026-01-28 at 8 37 30 AM

Screen widths < 800px

Screenshot 2026-01-28 at 8 36 06 AM

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@@ -0,0 +1,33 @@
.banner {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps consider migrating the CookieBanner to Material UI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on this suggestion. We are using some Material UI features in the component - are there additional things we can do here?

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions.

@rushtong
Copy link
Contributor Author

rushtong commented Jan 22, 2026

I have a few suggestions.

@fboulnois - this isn't approved by product yet - we're still in active conversations.

@rushtong rushtong marked this pull request as ready for review January 23, 2026 16:17
@rushtong rushtong requested a review from a team as a code owner January 23, 2026 16:17
@rushtong rushtong requested review from kevinmarete and otchet-broad and removed request for a team January 23, 2026 16:17
@rushtong rushtong requested a review from fboulnois January 23, 2026 18:17
Copy link
Contributor

@otchet-broad otchet-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Looks good!

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this window look a little more like our other windows?

Image

@rushtong

This comment was marked as resolved.

@sonarqubecloud
Copy link

@rushtong
Copy link
Contributor Author

@fboulnois @kevinmarete @otchet-broad - PTAL, this version of the design has product approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants