Skip to content

Conversation

@fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-2851

Summary

Currently, when clicking the AsyncSpinnerButton, no spinner is shown on long-running actions. This means the user gets no feedback that an operation is in progress. This fixes that issue, and adds a test to avoid regressions.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner January 28, 2026 15:41
@fboulnois fboulnois requested review from otchet-broad and rushtong and removed request for a team January 28, 2026 15:41
@fboulnois fboulnois force-pushed the fb-dt-2851-fix-async-spinner-button branch 3 times, most recently from a70353b to 7b2d5c2 Compare January 28, 2026 16:06
@fboulnois fboulnois force-pushed the fb-dt-2851-fix-async-spinner-button branch from 27cd8a2 to f4e4ee9 Compare January 28, 2026 16:56
@sonarqubecloud
Copy link

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit a98a317 into develop Jan 28, 2026
11 checks passed
@fboulnois fboulnois deleted the fb-dt-2851-fix-async-spinner-button branch January 28, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants