[DT-2848] Set-state-in-effect part 2: Switch useEffect to useMemo

[fboulnois]

Addresses

https://broadworkbench.atlassian.net/browse/DT-2848

Summary

The goal of this set of PRs is to decrease the number of warnings from ESLint to zero.

This PR removes a number of set-state-in-effect anti-patterns which cause extra renders and stale state bugs. This replaces several effect driven state updates with memoized computations or direct constants instead.

This decreases the number of ESLint warnings from 17 to 12 (-5).

---

Have you read Terra's Contributing Guide lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud