Skip to content

[DT-2832] Switch to dynamic elasticsearch index flag#3299

Closed
fboulnois wants to merge 1 commit intodevelopfrom
fb-dt-2832-switch-to-index-flag
Closed

[DT-2832] Switch to dynamic elasticsearch index flag#3299
fboulnois wants to merge 1 commit intodevelopfrom
fb-dt-2832-switch-to-index-flag

Conversation

@fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-2832

Summary

Dynamically switches the Elasticsearch index key name based on the appropriate feature flag.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner February 2, 2026 15:45
@fboulnois fboulnois requested review from kevinmarete and rushtong and removed request for a team February 2, 2026 15:45

const assembleFullQuery = (isSigningOfficial, isInstitutionQuery, subQuery) => {
const base = [{ match: { _type: 'dataset' } }, { exists: { field: 'study' } }]
const base = []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test mocks the query, hence this extra content is not needed.

Copy link
Contributor

@kevinmarete kevinmarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois force-pushed the fb-dt-2832-switch-to-index-flag branch from 94e8a6c to d876590 Compare February 4, 2026 20:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@fboulnois fboulnois closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants