Skip to content

Conversation

@calypsomatic
Copy link
Contributor

@calypsomatic calypsomatic commented Nov 24, 2025

Java-pfb logically belongs to the data team, not the core-services team.
https://broadworkbench.atlassian.net/browse/CTM-260

@calypsomatic calypsomatic requested a review from a team as a code owner November 24, 2025 14:13
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: dfc35ae Previous: 7b4ef46 Ratio
bio.terra.pfb.LibraryBenchmarks.showNodesMedium 1492.8908079642458 ops/s 1474.536611860186 ops/s 1.01
bio.terra.pfb.LibraryBenchmarks.showNodesSmall 22082.802800195488 ops/s 21914.329551949566 ops/s 1.01
bio.terra.pfb.PfbReaderBenchmarks.convertEnum 5273528.181015446 ops/s 5259104.629983816 ops/s 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@jgainerdewar jgainerdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @DataBiosphere/jadeteam may not exist?

@calypsomatic calypsomatic changed the title [TBD] Update CODEOWNERS to jade [CTM-260] Update CODEOWNERS to jade Nov 24, 2025
@calypsomatic
Copy link
Contributor Author

calypsomatic commented Nov 24, 2025

Looks like @DataBiosphere/jadeteam may not exist?

@jgainerdewar Dang, I thought I double-checked the team name - isn't it the same as in, e.g. https://github.com/DataBiosphere/terra-drs-hub/blob/dev/.github/CODEOWNERS. What are you seeing that suggests it doesn't exist?

@jgainerdewar
Copy link

I see this in the diff, and have a memory of these errors being meaningful in the past. If it looks okay to you maybe spurious, though?

Screenshot 2025-11-24 at 10 36 17 AM

@calypsomatic
Copy link
Contributor Author

calypsomatic commented Nov 24, 2025

I see this in the diff, and have a memory of these errors being meaningful in the past. If it looks okay to you maybe spurious, though?

Screenshot 2025-11-24 at 10 36 17 AM

@jgainerdewar Ah I see the team didn't have write access to the repo! Thanks for catching that, I've added them so hopefully it's valid now!

@calypsomatic calypsomatic merged commit 87f755e into main Nov 25, 2025
11 checks passed
@calypsomatic calypsomatic deleted the update-codeowners branch November 25, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants