-
Notifications
You must be signed in to change notification settings - Fork 0
[CTM-260] Update CODEOWNERS to jade #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Details
| Benchmark suite | Current: dfc35ae | Previous: 7b4ef46 | Ratio |
|---|---|---|---|
bio.terra.pfb.LibraryBenchmarks.showNodesMedium |
1492.8908079642458 ops/s |
1474.536611860186 ops/s |
1.01 |
bio.terra.pfb.LibraryBenchmarks.showNodesSmall |
22082.802800195488 ops/s |
21914.329551949566 ops/s |
1.01 |
bio.terra.pfb.PfbReaderBenchmarks.convertEnum |
5273528.181015446 ops/s |
5259104.629983816 ops/s |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
jgainerdewar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @DataBiosphere/jadeteam may not exist?
@jgainerdewar Dang, I thought I double-checked the team name - isn't it the same as in, e.g. https://github.com/DataBiosphere/terra-drs-hub/blob/dev/.github/CODEOWNERS. What are you seeing that suggests it doesn't exist? |
@jgainerdewar Ah I see the team didn't have write access to the repo! Thanks for catching that, I've added them so hopefully it's valid now! |





Java-pfb logically belongs to the data team, not the core-services team.
https://broadworkbench.atlassian.net/browse/CTM-260