AN-635 Fix log icon #801
Merged
AN-635 Fix log icon #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // to show users backend logs. | ||
| hasExternalLogs(): boolean { | ||
| return this.getExternalLogsUrl() != ''; | ||
| return this.getExternalLogsUrl() != '' && !this.backendLog; |
Contributor
There was a problem hiding this comment.
Is the expectation that the backendLog value will always be present when log policy is PATH, even if the file was actually never created or delocalized?
Collaborator
Author
There was a problem hiding this comment.
Correct, we always write the metadata (assuming we get to the point where that metadata for the task is written at all).
salonishah11
approved these changes
Jun 24, 2025
aednichols
approved these changes
Jun 24, 2025
lucymcnatt
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #800, in which the logs icon linked to Batch cloud log in cases where the backend log metadata item existed, but the file didn't exist or couldn't be read.