Introduce Option to Include Similar Nodegroups in Expander Options#112
Draft
BenHinthorne wants to merge 1 commit intodatadog-master-12.0from
Draft
Introduce Option to Include Similar Nodegroups in Expander Options#112BenHinthorne wants to merge 1 commit intodatadog-master-12.0from
BenHinthorne wants to merge 1 commit intodatadog-master-12.0from
Conversation
e17c1e7 to
4518ba3
Compare
rrangith
reviewed
Jun 14, 2024
841a011 to
c6af2c9
Compare
c6af2c9 to
614aa68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR updates the gRPC expanders Options request to include SimilarNodegroupIds. The purpose of adding this option is two fold:
An example use case for why users may want to filter the similar nodegroups in the gRPC expander is to filter nodegroups by a maximum number of nodes per zone, to prevent scaling in zones that experience IP Exhaustion (link issue). Another example would be that this allows users to prevent upscaling in zones in which they may have an outage, via filtering out these options via their gRPC expander.
It's also worth noting that the the other built-in expanders have SimilarNodegroups included by default, because the
expander.Optiontype includes similar nodegroups, it was only the *protos.Option type which did not.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: