✨[RUM-10962][Remote config] support js strategy#3766
Merged
Conversation
1cab81c to
bf779ef
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 081ac90 | Docs | Was this helpful? Give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
d2f02aa to
006d9a7
Compare
5d0b321 to
be71bfc
Compare
be71bfc to
fa484b2
Compare
fa484b2 to
06fe14f
Compare
bcaudan
commented
Sep 2, 2025
amortemousque
approved these changes
Sep 8, 2025
packages/rum-core/src/domain/configuration/remoteConfiguration.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/configuration/jsonPathParser.spec.ts
Outdated
Show resolved
Hide resolved
9738c5a to
9936cf2
Compare
9936cf2 to
081ac90
Compare
amortemousque
approved these changes
Sep 12, 2025
BenoitZugmeyer
approved these changes
Sep 12, 2025
rgaignault
pushed a commit
that referenced
this pull request
Sep 15, 2025
* ♻️ factorize extractor * ✨add simple JSON path parser * ✨add js strategy support * ⬆️ synchronize remote configuration schema * 👌remove unneeded cast * 👌add extra comments * 👌replace sets by lists * 👌use String.raw to avoid quote juggling * 👌some renamings * 👌remove useless types * 👌rework namings * 🐛fix escaping logic
mormubis
added a commit
that referenced
this pull request
Feb 2, 2026
Add 4 new E2E tests for the localStorage strategy: 1. Basic localStorage retrieval - reads simple string values 2. localStorage with regex extractor - parses extracted values 3. Missing key handling - gracefully falls back when key doesn't exist 4. localStorage unavailable - handles access errors and falls back Tests follow the same pattern as the js strategy tests (PR #3766) and validate: - Synchronous value resolution during SDK initialization - Regex extraction functionality - Fallback behavior for missing or inaccessible keys - Integration with both CDN and npm setups Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
mormubis
added a commit
that referenced
this pull request
Feb 4, 2026
Add 4 new E2E tests for the localStorage strategy: 1. Basic localStorage retrieval - reads simple string values 2. localStorage with regex extractor - parses extracted values 3. Missing key handling - gracefully falls back when key doesn't exist 4. localStorage unavailable - handles access errors and falls back Tests follow the same pattern as the js strategy tests (PR #3766) and validate: - Synchronous value resolution during SDK initialization - Regex extraction functionality - Fallback behavior for missing or inaccessible keys - Integration with both CDN and npm setups Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
mormubis
added a commit
that referenced
this pull request
Feb 12, 2026
Add 4 new E2E tests for the localStorage strategy: 1. Basic localStorage retrieval - reads simple string values 2. localStorage with regex extractor - parses extracted values 3. Missing key handling - gracefully falls back when key doesn't exist 4. localStorage unavailable - handles access errors and falls back Tests follow the same pattern as the js strategy tests (PR #3766) and validate: - Synchronous value resolution during SDK initialization - Regex extraction functionality - Fallback behavior for missing or inaccessible keys - Integration with both CDN and npm setups Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support resolving a remote configuration option to a js variable value by using a simple JSON path.
Changes
Test instructions
No backend to test the new options yet
Checklist