🐛[RUM-11247] Pass down error stack to isAllowedTrackingOrigins#3824
🐛[RUM-11247] Pass down error stack to isAllowedTrackingOrigins#3824dd-mergequeue[bot] merged 27 commits intomainfrom
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: e31f5cb | Docs | Was this helpful? Give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
cbf7b31 to
5844f86
Compare
This reverts commit 51cfd95.
packages/rum-core/src/domain/configuration/configuration.spec.ts
Outdated
Show resolved
Hide resolved
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit e31f5cb6e9 will soon be integrated into staging-39.
Commit e31f5cb6e9 has been merged into staging-39 in merge commit 077c92b6db. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Integrated commit sha: e31f5cb Co-authored-by: BeltranBulbarellaDD <beltran.bulbarella@datadoghq.com>
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Motivation
Currently there are 9 function calls before
isAllowedTrackingOrigins. Chrome passes the first 9, so if we were to add 1 more function call before, we would never get the extension prefix in the stackChanges
Created the error stack in
makeRumPublicApiandmakeLogsPublicApiand passed it down toisAllowedTrackingOriginsfunction.(First error is the new stack, second error is the previous stack)

Test instructions
Use the dev extension and inject it in localHost:8080 while running the local SDK. If you print the error stack that
isAllowedTrackingOriginsreceives now and print a new error stack below it should be the same as the image above. We should see the error stack in a different location, closer to the top.Also, to test the new detection logic. Go to a page that uses RUM, and install a browser extension, use the Local SDK on the page. Without this PR you should see the
WARN_DOES_NOT_HAVE_ALLOWED_TRACKING_ORIGINnow you should seeSDK is loaded more than once. This is unsupported and might have unexpected behavior.Checklist