Skip to content

🔉 report missing configuration options#3832

Merged
BenoitZugmeyer merged 2 commits intomainfrom
benoit/report-missing-configuration-options
Sep 10, 2025
Merged

🔉 report missing configuration options#3832
BenoitZugmeyer merged 2 commits intomainfrom
benoit/report-missing-configuration-options

Conversation

@BenoitZugmeyer
Copy link
Member

Motivation

Some new configuration options were not reported as telemetry. I am mostly interested in the profiling_sample_rate see when an org starts using profiling.

Changes

Include those new configuration options in telemetry.

Test instructions

Check if those options are reported as telemetry

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 9, 2025 17:21
@datadog-official
Copy link

datadog-official bot commented Sep 9, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.61% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a348b5b | Docs | Was this helpful? Give us feedback!

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/report-missing-configuration-options branch from 53a972d to a348b5b Compare September 9, 2025 17:23
@cit-pr-commenter
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 156.51 KiB 156.66 KiB 152 B 0.09%
Rum Recorder 19.53 KiB 19.53 KiB 0 B 0.00%
Rum Profiler 5.18 KiB 5.18 KiB 0 B 0.00%
Logs 55.12 KiB 55.12 KiB 0 B 0.00%
Flagging N/A 931 B 931 B N/A%
Rum Slim 114.29 KiB 114.44 KiB 152 B 0.13%
Worker 23.60 KiB 23.60 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.013 0.010 -0.003
addaction 0.040 0.029 -0.011
addtiming 0.008 0.006 -0.002
adderror 0.035 0.025 -0.010
startstopsessionreplayrecording 0.002 0.002 -0.001
startview 0.012 0.009 -0.002
logmessage 0.044 0.026 -0.018
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 26.10 KiB 24.81 KiB -1326 B
addaction 46.71 KiB 45.11 KiB -1631 B
addtiming 24.60 KiB 24.96 KiB 374 B
adderror 51.67 KiB 50.26 KiB -1449 B
startstopsessionreplayrecording 23.95 KiB 23.85 KiB -97 B
startview 424.92 KiB 428.13 KiB 3.22 KiB
logmessage 42.26 KiB 41.90 KiB -362 B

🔗 RealWorld

@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 9, 2025

View all feedbacks in Devflow UI.

2025-09-09 18:12:40 UTC ℹ️ Start processing command /to-staging


2025-09-09 18:12:54 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 16m (p90)

Commit a348b5b2cb will soon be integrated into staging-37.


2025-09-09 18:13:14 UTC 🚨 Branch Integration: this merge request has conflicts which couldn't be solved automatically

We couldn't automatically merge the commit a348b5b2cb into staging-37!

To solve the conflicts directly in Github, click here to create a fix pull request.

Alternatively, you can also click here reset the integration branch or use the following Slack command: /devflow reset-branch -r browser-sdk -b staging-37

dd-devflow bot added a commit that referenced this pull request Sep 9, 2025
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 9, 2025

🚂 Branch Integration: starting soon, merge expected in approximately 16m (p90)

Commit a348b5b2cb will soon be integrated into staging-37.

@dd-devflow dd-devflow bot added the staging-37 label Sep 9, 2025
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 9, 2025

🚂 Branch Integration

Commit a348b5b2cb has been merged into staging-37 in merge commit de4180252d.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-37

@BenoitZugmeyer BenoitZugmeyer merged commit e422f97 into main Sep 10, 2025
20 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/report-missing-configuration-options branch September 10, 2025 14:34
BeltranBulbarellaDD pushed a commit that referenced this pull request Sep 12, 2025
* update rum-events-schema

* report missing configuration options as telemetry
rgaignault pushed a commit that referenced this pull request Sep 15, 2025
* update rum-events-schema

* report missing configuration options as telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants