-
Notifications
You must be signed in to change notification settings - Fork 163
🔧 migrate the developer-extension to wxt #3962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BenoitZugmeyer
wants to merge
6
commits into
main
Choose a base branch
from
benoit/migrate-devext-to-wxt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,769
−1,244
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bcdba36
🔧 migrate the developer-extension to wxt
BenoitZugmeyer 2d15023
✅ fix e2e test
BenoitZugmeyer adfe4ec
edit readme
BenoitZugmeyer a8e1c7c
merge main branch
BenoitZugmeyer 4c3a646
Apply suggestions from code review
BenoitZugmeyer ab845f9
👌 remove build warning
BenoitZugmeyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,14 +24,12 @@ dev,@types/node-forge,MIT,Copyright Microsoft Corporation | |
| dev,@types/pako,MIT,Copyright Microsoft Corporation | ||
| dev,@types/react,MIT,Copyright Microsoft Corporation | ||
| dev,@types/react-dom,MIT,Copyright Microsoft Corporation | ||
| dev,@webextension-toolbox/webpack-webextension-plugin,MIT,Copyright 2018 Henrik Wenz ([email protected]) | ||
| dev,@wxt-dev/module-react,MIT,Copyright (c) 2023 Aaron | ||
| dev,ajv,MIT,Copyright 2015-2017 Evgeny Poberezkin | ||
| dev,browserstack-local,MIT,Copyright 2016 BrowserStack | ||
| dev,chrome-webstore-upload,MIT,Copyright Federico Brigante <[email protected]> (https://fregante.com), 2020 Andrew Levine | ||
| dev,connect-busboy,MIT,Copyright Brian White | ||
| dev,copy-webpack-plugin,MIT,Copyright JS Foundation and other contributors | ||
| dev,cors,MIT,Copyright 2013 Troy Goode | ||
| dev,css-loader,MIT,Copyright JS Foundation and other contributors | ||
| dev,emoji-name-map,MIT,Copyright 2016-19 Ionică Bizău <[email protected]> (https://ionicabizau.net) | ||
| dev,eslint,MIT,Copyright JS Foundation and other contributors | ||
| dev,eslint-module-utils,MIT,Copyright (c) 2015 Ben Mosher | ||
|
|
@@ -60,7 +58,6 @@ dev,pako,MIT,(C) 2014-2017 Vitaly Puzrin and Andrey Tupitsin | |
| dev,prettier,MIT,Copyright James Long and contributors | ||
| dev,puppeteer,Apache-2.0,Copyright 2017 Google Inc. | ||
| dev,react-router-dom,MIT,Copyright (c) React Training LLC 2015-2019 Copyright (c) Remix Software Inc. 2020-2021 Copyright (c) Shopify Inc. 2022-2023 | ||
| dev,style-loader,MIT,Copyright JS Foundation and other contributors | ||
| dev,terser-webpack-plugin,MIT,Copyright JS Foundation and other contributors | ||
| dev,ts-loader,MIT,Copyright 2015 TypeStrong | ||
| dev,ts-node,MIT,Copyright 2014 Blake Embrey | ||
|
|
@@ -72,10 +69,6 @@ dev,webpack-cli,MIT,Copyright JS Foundation and other contributors | |
| dev,webpack-dev-middleware,MIT,Copyright JS Foundation and other contributors | ||
| dev,@swc/core,Apache-2.0,Copyright (c) SWC Contributors | ||
| dev,swc-loader,MIT,Copyright (c) SWC Contributors | ||
| dev,@pmmmwh/react-refresh-webpack-plugin,MIT,Copyright (c) Michael Mok | ||
| dev,@types/webpack-env,MIT,Copyright Microsoft Corporation | ||
| dev,react-refresh,MIT,Copyright (c) Facebook, Inc. and its affiliates. | ||
| dev,react-refresh-typescript,MIT,Copyright (c) Piotr Monwid-Olechnowicz | ||
| dev,webpack-dev-server,MIT,Copyright JS Foundation and other contributors | ||
| dev,http-server,MIT,Copyright http-party contributors | ||
| dev,react-router,MIT,Copyright (c) React Training LLC 2015-2019 Copyright (c) Remix Software Inc. 2020-2021 Copyright (c) Shopify Inc. 2022-2023 | ||
| dev,wxt,MIT,Copyright (c) 2023 Aaron | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // eslint-disable-next-line import/no-unresolved | ||
| import { defineBackground } from 'wxt/utils/define-background' | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default defineBackground(() => { | ||
| void import('../background') | ||
| }) |
10 changes: 10 additions & 0 deletions
10
developer-extension/src/entrypoints/contentScriptIsolated.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // eslint-disable-next-line import/no-unresolved | ||
| import { defineContentScript } from 'wxt/utils/define-content-script' | ||
| import { main } from '../content-scripts/isolated' | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default defineContentScript({ | ||
| matches: ['<all_urls>'], | ||
| world: 'ISOLATED', | ||
| main, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // eslint-disable-next-line import/no-unresolved | ||
| import { defineContentScript } from 'wxt/utils/define-content-script' | ||
| import { main } from '../content-scripts/main' | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default defineContentScript({ | ||
| matches: ['<all_urls>'], | ||
| world: 'MAIN', | ||
| main, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <script type="module" src="../devtools"></script> | ||
| </head> | ||
| <body></body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="../panel"></script> | ||
| </body> | ||
| </html> |
4 changes: 2 additions & 2 deletions
4
developer-extension/src/panel/components/tabs/eventsTab/facetList.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
developer-extension/src/panel/components/tabs/eventsTab/rowButton.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clarify why we need this? As we didn't have it before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did have it before, just not as a separate file. I linked to MDN docs in the README to clarify a bit the architecture.