Skip to content

👷 handle undefined api key for source-maps upload to new DC #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+18 −7
Merged

👷 handle undefined api key for source-maps upload to new DC #3971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions scripts/deploy/upload-source-maps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,13 @@ function uploadToDatadog(
sites: string[]
): void {
for (const site of sites) {
if (!site) {
printLog(`No source maps upload configured for ${site}, skipping...`)
const apiKey = getTelemetryOrgApiKey(site)

if (!apiKey) {
printLog(`No API key configured for ${site}, skipping...`)
continue
}

printLog(`Uploading ${packageName} source maps with prefix ${prefix} for ${site}...`)

command`
Expand All @@ -103,7 +106,7 @@ function uploadToDatadog(
--repository-url https://www.github.com/datadog/browser-sdk
`
.withEnvironment({
DATADOG_API_KEY: getTelemetryOrgApiKey(site),
DATADOG_API_KEY: apiKey,
DATADOG_SITE: site,
})
.run()
Expand Down
16 changes: 12 additions & 4 deletions scripts/lib/secrets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,22 @@ export function getOrg2AppKey(): string {
return getSecretKey('ci.browser-sdk.datadog_ci_application_key')
}

export function getTelemetryOrgApiKey(site: string): string {
export function getTelemetryOrgApiKey(site: string): string | undefined {
const normalizedSite = site.replaceAll('.', '-')
return getSecretKey(`ci.browser-sdk.source-maps.${normalizedSite}.ci_api_key`)
try {
return getSecretKey(`ci.browser-sdk.source-maps.${normalizedSite}.ci_api_key`)
} catch {
return
}
}

export function getTelemetryOrgApplicationKey(site: string): string {
export function getTelemetryOrgApplicationKey(site: string): string | undefined {
const normalizedSite = site.replaceAll('.', '-')
return getSecretKey(`ci.browser-sdk.telemetry.${normalizedSite}.ci_app_key`)
try {
return getSecretKey(`ci.browser-sdk.telemetry.${normalizedSite}.ci_app_key`)
} catch {
return
}
}

export function getNpmToken(): string {
Expand Down