💥 [RUM-14058] Use tree walker for action name computation#3972
💥 [RUM-14058] Use tree walker for action name computation#3972BenoitZugmeyer merged 2 commits intov7from
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
4c2d9ec to
c6da46a
Compare
c6da46a to
9fee568
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit 77d6150a9f will soon be integrated into staging-09.
Commit 77d6150a9f has been merged into staging-09 in merge commit d181f5111a. Check out the triggered DDCI request. If you need to revert this integration, you can use the following command: |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 77d6150 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Integrated commit sha: 77d6150 Co-authored-by: BenoitZugmeyer <benoit.zugmeyer@datadoghq.com>
|
/code revert-integration -b staging-09 |
|
View all feedbacks in Devflow UI.
An error occurred when reverting d181f51. You can manually perform the revert with the following commands: Then you can push and create a pull request to merge your commit. DetailsMerge conflict To get help about command usage, write If you need support, contact us on Slack #devflow with those details! |
sethfowler-datadog
left a comment
There was a problem hiding this comment.
Looks great; glad to see this one getting enabled by default!
Motivation
We have tested tree walker approach and the previous approach of action name computation back to back, it seems that the risk of switching to tree walker is low (results are identical on staging). The tree walker approach is more secure and efficient. It also gives alignment between action name and SR rendered texts.
Changes
Remove feature flag of using treewalker
Remove legacy action name compuation approach
Fix test cases by removing the FF mock
Test instructions
Should pass CI
Checklist