Skip to content

👷 improve static analysis#4030

Merged
BenoitZugmeyer merged 6 commits intomainfrom
benoit/improve-static-analysis
Dec 17, 2025
Merged

👷 improve static analysis#4030
BenoitZugmeyer merged 6 commits intomainfrom
benoit/improve-static-analysis

Conversation

@BenoitZugmeyer
Copy link
Member

Motivation

Currently, we need to build the SDK before running lint or typecheck commands. The goal of this PR is to get rid of this requirement.

Changes

See commits, but the two main changes were to:

  • consolidate the typescript path config with all our local entry points so typescript can resolve source files instead of built files
  • use the eslint-import-resolver-typescript so eslint takes the path config into consideration

Test instructions

CI should be enough

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner December 12, 2025 17:13
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 12, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.34 KiB 164.34 KiB 0 B 0.00%
Rum Profiler 4.32 KiB 4.32 KiB 0 B 0.00%
Rum Recorder 20.02 KiB 20.02 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.62 KiB 121.62 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0042 0.006 +42.86%
RUM - add action 0.0121 0.0173 +42.98%
RUM - add error 0.0117 0.0188 +60.68%
RUM - add timing 0.0029 0.0048 +65.52%
RUM - start view 0.0033 0.0057 +72.73%
RUM - start/stop session replay recording 0.0007 0.001 +42.86%
Logs - log message 0.0137 0.0246 +79.56%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.04 KiB 25.21 KiB -849 B
RUM - add action 48.30 KiB 47.90 KiB -416 B
RUM - add timing 24.12 KiB 24.29 KiB +170 B
RUM - add error 53.90 KiB 54.31 KiB +419 B
RUM - start/stop session replay recording 23.28 KiB 25.05 KiB +1.77 KiB
RUM - start view 424.06 KiB 422.03 KiB -2.03 KiB
Logs - log message 44.77 KiB 44.58 KiB -192 B

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 12, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 92.68% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 20ce52f | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@BenoitZugmeyer
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 17, 2025

View all feedbacks in Devflow UI.

2025-12-17 12:28:23 UTC ℹ️ Start processing command /merge


2025-12-17 12:28:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 52m (p90).


2025-12-17 12:52:10 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for e71ec3f:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@BenoitZugmeyer BenoitZugmeyer merged commit 250f6cd into main Dec 17, 2025
21 of 22 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/improve-static-analysis branch December 17, 2025 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants