🐛 [RUM-13741] Fix sibling uniqueness check for elements in DocumentFragment #4115
+34
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes a recurrent error in the sdk telemetry.
The error happens because
currentElement.parentElementcan actually benull, for example when the parent is a document fragment (in that case the parent is aDocument, not anElement.)Instead of relying on
parent.firstElementChildto iterate siblings, the fix uses direct sibling traversal:previousElementSibling(backward)nextElementSibling(forward)This approach works regardless of parent type, including when
parentElementisnull.Changes
parent.firstElementChilditeration with directpreviousElementSiblingandnextElementSiblingtraversalTest instructions
Checklist