[DRAFT] ⚗️ Set view.in_foreground on all non-View RUM events

packages/rum-core/src/domain/contexts/pageStateHistory.spec.ts

@@ -175,7 +175,7 @@ describe('pageStateHistory', () => {
       })
     })
   })
-  ;[RumEventType.ACTION, RumEventType.ERROR].forEach((eventType) => {
+  ;[RumEventType.ACTION, RumEventType.ERROR, RumEventType.RESOURCE, RumEventType.LONG_TASK, RumEventType.VITAL].forEach((eventType) => {
     describe(`for ${eventType} events`, () => {
       let pageStateHistory: PageStateHistory
 

packages/rum-core/src/domain/contexts/pageStateHistory.ts

@@ -1,6 +1,5 @@
 import type { Duration, RelativeTime } from '@datadog/browser-core'
 import {
-  SKIPPED,
   elapsed,
   createValueHistory,
   SESSION_TIME_OUT_DELAY,
@@ -101,7 +100,7 @@ export function startPageStateHistory(
 
   hooks.register(
     HookNames.Assemble,
-    ({ startTime, duration = 0 as Duration, eventType }): DefaultRumEventAttributes | SKIPPED => {
+    ({ startTime, duration = 0 as Duration, eventType }): DefaultRumEventAttributes => {
       if (eventType === RumEventType.VIEW) {
         const pageStates = pageStateEntryHistory.findAll(startTime, duration)
         return {
@@ -110,14 +109,10 @@ export function startPageStateHistory(
         }
       }
 
-      if (eventType === RumEventType.ACTION || eventType === RumEventType.ERROR) {
-        return {
-          type: eventType,
-          view: { in_foreground: wasInPageStateDuringPeriod(PageState.ACTIVE, startTime, 0 as Duration) },
-        }
+      return {
+        type: eventType,
+        view: { in_foreground: wasInPageStateDuringPeriod(PageState.ACTIVE, startTime, 0 as Duration) },
       }
-
-      return SKIPPED
     }
   )
 

packages/rum-core/src/rawRumEvent.types.ts

@@ -75,6 +75,9 @@ export interface RawRumResourceEvent {
     delivery_type?: DeliveryType
     graphql?: GraphQlMetadata
   }
+  view?: {
+    in_foreground: boolean
+  }
   _dd: {
     trace_id?: string
     span_id?: string // not available for initial document tracing
@@ -261,6 +264,9 @@ export interface RawRumLongTaskEvent {
     entry_type: typeof RumLongTaskEntryType.LONG_TASK
     duration: ServerDuration
   }
+  view?: {
+    in_foreground: boolean
+  }
   _dd: {
     discarded: boolean
   }
@@ -302,6 +308,9 @@ export interface RawRumLongAnimationFrameEvent {
       window_attribution: string
     }>
   }
+  view?: {
+    in_foreground: boolean
+  }
   _dd: {
     discarded: boolean
   }
@@ -378,6 +387,9 @@ export interface RawRumVitalEvent {
     description?: string
     duration?: number
   }
+  view?: {
+    in_foreground: boolean
+  }
   _dd?: {
     vital: {
       computed_value: true

packages/rum-core/src/rumEvent.types.ts

@@ -606,6 +606,16 @@ export type RumLongTaskEvent = CommonProperties &
       }[]
       [k: string]: unknown
     }
+    /**
+     * View properties
+     */
+    readonly view?: {
+      /**
+       * Is the long task starting in the foreground (focus in browser)
+       */
+      readonly in_foreground?: boolean
+      [k: string]: unknown
+    }
     /**
      * Internal properties
      */
@@ -921,6 +931,16 @@ export type RumResourceEvent = CommonProperties &
       }
       [k: string]: unknown
     }
+    /**
+     * View properties
+     */
+    readonly view?: {
+      /**
+       * Is the resource starting in the foreground (focus in browser)
+       */
+      readonly in_foreground?: boolean
+      [k: string]: unknown
+    }
     /**
      * Internal properties
      */
@@ -1393,6 +1413,16 @@ export type RumVitalEventCommonProperties = CommonProperties &
      * RUM event type
      */
     readonly type: 'vital'
+    /**
+     * View properties
+     */
+    readonly view?: {
+      /**
+       * Is the vital starting in the foreground (focus in browser)
+       */
+      readonly in_foreground?: boolean
+      [k: string]: unknown
+    }
     /**
      * Vital properties
      */