ACIX-1062: Create helper function for go build
#211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1062-go-build-helper
branch
3 times, most recently
from
69b83fd to
44d3f4b
Compare
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1062-go-build-helper
branch
from
c73f2fc to
58a61e2
Compare
Ishirui
changed the title
go build
…o build` Also restructures a bit the tests directory for `go`
This way we can use the build cache if needed, which is useful for example in the `test_build_project` test which rebuilds more or less the same project twice.
…rting with `-` This would cause a failure in `test_command_formation` if the entrypoint starts with `-`, as it would then be considered a flag instead of a parameter
…ecific operating systems
…not installed in CI runners
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1062-go-build-helper
branch
from
58a61e2 to
37748c8
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new build() helper method to the Go tool wrapper for running instrumented go build commands with various compilation flags. The implementation includes comprehensive test coverage with both unit tests for command formation and integration tests using a small Go project fixture.
Key Changes:
- Added
Go.build()method with support for build tags, compiler/linker flags, and platform-specific race detection - Reorganized test structure by moving
tests/tools/test_go.pytotests/tools/go/test_go.py - Added test fixtures including a small Go project with build tag support
- Enhanced test infrastructure with new pytest markers for skipping tests on specific platforms
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/dda/tools/go.py |
Adds build() and _build() methods for wrapping go build with automatic flag management and race detection |
tests/tools/go/test_go.py |
Moved and expanded tests with parametrized test cases for command formation and integration tests |
tests/tools/go/conftest.py |
Adds get_random_filename fixture for generating test file paths |
tests/tools/go/__init__.py |
New package initialization file |
tests/tools/go/fixtures/small_go_project/* |
Test fixture Go project with build tags for integration testing |
tests/conftest.py |
Adds skip_* pytest markers for platform-specific test skipping and fixes requires_unix condition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Additionnal quoting around some arguments - Pass `tags` as a comma-separated list - Pass custom env vars to the build command - `-mod` argument has a different purpose than previously thought
ofek
approved these changes
Dec 12, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
* feat(go): Add a custom `Go.build` method for easier invocations of `go build`
Also restructures a bit the tests directory for `go`
* fix(go): Make the `-a` argument controllable
This way we can use the build cache if needed, which is useful for example in the `test_build_project` test which rebuilds more or less the same project twice.
* fix(build): Prevent `get_random_filename` from creating filenames starting with `-`
This would cause a failure in `test_command_formation` if the entrypoint starts with `-`, as it would then be considered a flag instead of a parameter
* feat(tests): Add `skip_${OS}` pytest markers for skipping tests on specific operating systems
* fix(tests): Skip `TestBuild::test_build_project` on macOS as `go` is not installed in CI runners
* fix(go): Tweak `Go.build` method interface after testing
- Additionnal quoting around some arguments
- Pass `tags` as a comma-separated list
- Pass custom env vars to the build command
- `-mod` argument has a different purpose than previously thought
* refactor: Minor Copilot-suggested tweaks
* refactor: Simplify `get_random_filename` test fixture
* refactor(go): Pass `*packages` instead of a single `entrypoint`
* refactor(tests): Use sets of build tags everywhere
* feat(go): Allow passing 0 packages to `build` method
* refactor(tests): `get_random_filename` returns a simple `str` fd65f14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple method wrapping
go buildfor use in dda build commands.