Skip to content

fix(install): Another try to have a proper argument split #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofek merged 8 commits into from
Mar 31, 2025
Merged

fix(install): Another try to have a proper argument split #56

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47857c6
fix(install): Another try to have a proper argument split
chouetz Mar 31, 2025
71ea64c
use alternative method to parse features
chouetz Mar 31, 2025
be3fe03
Apply suggestions from code review
ofek Mar 31, 2025
e0c9323
Apply suggestions from code review
ofek Mar 31, 2025
2aa104e
Apply suggestions from code review
ofek Mar 31, 2025
0d438bb
Apply suggestions from code review
ofek Mar 31, 2025
1a9a900
Apply suggestions from code review
ofek Mar 31, 2025
0c81278
Apply suggestions from code review
ofek Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions main.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,15 @@ install_features() {
if [[ -n "${FEATURES}" ]]; then
echo -e "${PURPLE}Installing features: ${FEATURES}${RESET}"

# ARGS=$(echo "$FEATURES" | awk 'BEGIN{ORS=" "}{for (i=1;i<=NF;i++){print "--feature",$i}}')
ARGS=()
for feature in $(echo $FEATURES); do
for feature in $FEATURES; do
ARGS+=("-f" "$feature")
done
echo ${ARGS[@]}

"${1}" -v self dep sync "${ARGS[@]}"
echo "${1} -v self dep sync ${ARGS[@]}"
"${1}" -v self dep sync ${ARGS[@]}
fi
}

Expand Down