Skip to content

Commit f301c25

Browse files
authored
remove flake mark for changed system files test (#47535)
### What does this PR do? remove flake mark for changed system files test ### Motivation hasn't failed in awhile and it makes our flaky test report hard to read because this subtest is used in many places and they're all reported individually Co-authored-by: branden.clark <branden.clark@datadoghq.com>
1 parent ebd4d55 commit f301c25

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

test/new-e2e/tests/windows/install-test/system_file_tester.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ package installtest
88
import (
99
"testing"
1010

11-
"github.com/DataDog/datadog-agent/pkg/util/testutil/flake"
1211
"github.com/DataDog/datadog-agent/test/e2e-framework/testing/components"
1312
windowsCommon "github.com/DataDog/datadog-agent/test/new-e2e/tests/windows/common"
1413
"github.com/stretchr/testify/assert"
@@ -59,7 +58,10 @@ func AssertDoesNotRemoveSystemFiles(t *testing.T, host *components.RemoteHost, b
5958
// we mark it as flaky so it doesn't block PRs.
6059
// See WINA-624 for investigation into better ways to perform this test.
6160
// If new Windows paths must be ignored, add them to the ignorePaths list in SystemPaths.
62-
flake.Mark(tt)
61+
// NOTE: not marked as flaky for now because it hasn't failed in a long time
62+
// and it makes our flake reports hard to read because this subtest is used in many places.
63+
// flake.Mark(tt)
64+
6365
assert.Empty(tt, result, "should not remove system files")
6466
})
6567
}

0 commit comments

Comments
 (0)