Skip to content

[EUDM] Collect Mac system information#44301

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 21 commits intomainfrom
brian.tu/host-hardware-mac
Jan 21, 2026
Merged

[EUDM] Collect Mac system information#44301
gh-worker-dd-mergequeue-cf854d[bot] merged 21 commits intomainfrom
brian.tu/host-hardware-mac

Conversation

@briantu
Copy link
Contributor

@briantu briantu commented Dec 16, 2025

What does this PR do?

Mac implementation to collect system hardware information. Stacked on top of @mrafi97's branch mrafi/host-hardware #44952.

Motivation

https://datadoghq.atlassian.net/browse/WINA-2081

Describe how you validated your changes

  • Added unit tests
  • Diagnose command
    1. dda inv agent.build --build-exclude=systemd
    2. Add infrastructure_mode: end_user_device and cmd_port: 5051 (IPC server doesn't automatically run for dev builds, required for diagnose command) to bin/agent/dist/datadog.yaml
    3. ./bin/agent/agent run -c bin/agent/dist/datadog.yaml &
    4. ./bin/agent/agent -c bin/agent/dist/datadog.yaml diagnose show-metadata host-system-info
{
    "hostname": "test-hostname",
    "timestamp": 1768324940565060000,
    "host_system_info_metadata": {
        "manufacturer": "Apple Inc.",
        "model_number": "Z1FD000AYLL/A",
        "serial_number": "G0FHNH5647",
        "model_name": "MacBook Pro (14-inch, Nov 2024)",
        "chassis_type": "Laptop",
        "identifier": "Mac16,6"
    },
    "uuid": "18951416-a4d7-5ab4-b253-49733fcc5f59"
}

Additional Notes

@briantu briantu force-pushed the brian.tu/host-hardware-mac branch from 1f91818 to aaba2be Compare December 16, 2025 16:33
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor e0ec13b
📊 Static Quality Gates Dashboard

Error

Quality gate Change Size (prev → curr → max)
⚠️ agent_msi neutral 572.094 MiB
Gate failure full details
Quality gate Error type Error message
agent_msi StaticQualityGateFailed (non-blocking: size unchanged from ancestor) �[91mstatic_quality_gate_agent_msi failed!
Wire size 143.1 MB exceeds limit of 143.0 MB by 39.5 KB�[0m

Note: Some gates exceeded limits but are non-blocking because the size hasn't increased from the ancestor commit.

30 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 704.917 MiB
agent_deb_amd64_fips 700.198 MiB
agent_heroku_amd64 327.192 MiB
agent_rpm_amd64 704.903 MiB
agent_rpm_amd64_fips 700.185 MiB
agent_rpm_arm64 686.270 MiB
agent_rpm_arm64_fips 682.364 MiB
agent_suse_amd64 704.903 MiB
agent_suse_amd64_fips 700.185 MiB
agent_suse_arm64 686.270 MiB
agent_suse_arm64_fips 682.364 MiB
docker_agent_amd64 767.044 MiB
docker_agent_arm64 772.978 MiB
docker_agent_jmx_amd64 957.923 MiB
docker_agent_jmx_arm64 952.576 MiB
docker_cluster_agent_amd64 180.769 MiB
docker_cluster_agent_arm64 196.603 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.863 MiB
docker_dogstatsd_arm64 37.128 MiB
dogstatsd_deb_amd64 30.082 MiB
dogstatsd_deb_arm64 28.223 MiB
dogstatsd_rpm_amd64 30.082 MiB
dogstatsd_suse_amd64 30.082 MiB
iot_agent_deb_amd64 43.163 MiB
iot_agent_deb_arm64 40.268 MiB
iot_agent_deb_armhf 40.857 MiB
iot_agent_rpm_amd64 43.163 MiB
iot_agent_suse_amd64 43.163 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
⚠️ agent_msi -12.0 KiB (0.01% reduction) 143.070 → 143.059 → 143.020
agent_deb_amd64 -56.87 KiB (0.03% reduction) 173.447 → 173.391 → 174.490
agent_deb_amd64_fips -6.41 KiB (0.00% reduction) 172.328 → 172.321 → 173.750
agent_heroku_amd64 -5.68 KiB (0.01% reduction) 87.169 → 87.163 → 88.450
agent_rpm_amd64 -32.71 KiB (0.02% reduction) 176.432 → 176.400 → 177.660
agent_rpm_amd64_fips +9.71 KiB (0.01% increase) 174.947 → 174.956 → 176.600
agent_rpm_arm64 +44.63 KiB (0.03% increase) 159.452 → 159.496 → 161.260
agent_rpm_arm64_fips -27.06 KiB (0.02% reduction) 158.957 → 158.930 → 160.550
agent_suse_amd64 -32.71 KiB (0.02% reduction) 176.432 → 176.400 → 177.660
agent_suse_amd64_fips +9.71 KiB (0.01% increase) 174.947 → 174.956 → 176.600
agent_suse_arm64 +44.63 KiB (0.03% increase) 159.452 → 159.496 → 161.260
agent_suse_arm64_fips -27.06 KiB (0.02% reduction) 158.957 → 158.930 → 160.550
docker_agent_amd64 neutral 260.991 MiB
docker_agent_arm64 +5.53 KiB (0.00% increase) 249.971 → 249.976 → 252.630
docker_agent_jmx_amd64 neutral 329.626 MiB
docker_agent_jmx_arm64 +4.55 KiB (0.00% increase) 314.591 → 314.595 → 317.270
docker_cluster_agent_amd64 neutral 63.875 MiB
docker_cluster_agent_arm64 neutral 60.150 MiB
docker_cws_instrumentation_amd64 neutral 2.995 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 neutral 15.043 MiB
docker_dogstatsd_arm64 neutral 14.364 MiB
dogstatsd_deb_amd64 neutral 7.957 MiB
dogstatsd_deb_arm64 neutral 6.832 MiB
dogstatsd_rpm_amd64 neutral 7.968 MiB
dogstatsd_suse_amd64 neutral 7.968 MiB
iot_agent_deb_amd64 neutral 11.312 MiB
iot_agent_deb_arm64 neutral 9.665 MiB
iot_agent_deb_armhf neutral 9.865 MiB
iot_agent_rpm_amd64 +5.87 KiB (0.05% increase) 11.327 → 11.333 → 12.060
iot_agent_suse_amd64 +5.87 KiB (0.05% increase) 11.327 → 11.333 → 12.060

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 16, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6f143f82-ab27-4890-9d09-69bd3749e91e

Baseline: e0ec13b
Comparison: be0fa7e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.89 [-4.82, +1.04] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.58 [+0.54, +0.62] 1 Logs bounds checks dashboard
file_tree memory utilization +0.51 [+0.45, +0.56] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.37 [+0.20, +0.53] 1 Logs
docker_containers_memory memory utilization +0.26 [+0.19, +0.33] 1 Logs
otlp_ingest_metrics memory utilization +0.14 [-0.02, +0.29] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.10 [+0.04, +0.16] 1 Logs
ddot_metrics memory utilization +0.06 [-0.16, +0.28] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.39, +0.45] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.37, +0.41] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.48, +0.51] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.13] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.14, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.11, +0.08] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.07, +0.02] 1 Logs
quality_gate_idle_all_features memory utilization -0.09 [-0.13, -0.06] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.15 [-0.26, -0.04] 1 Logs
ddot_logs memory utilization -0.34 [-0.41, -0.26] 1 Logs
ddot_metrics_sum_delta memory utilization -0.42 [-0.62, -0.22] 1 Logs
quality_gate_metrics_logs memory utilization -0.44 [-0.65, -0.22] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.69 [-0.92, -0.47] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.89 [-0.98, -0.81] 1 Logs
quality_gate_logs % cpu utilization -1.47 [-2.90, -0.03] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -1.89 [-4.82, +1.04] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 11 (x3) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 11 (x3) Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@mrafi97 mrafi97 force-pushed the mrafi/host-hardware branch from 9bcbc2b to 76e2dac Compare January 9, 2026 15:01
@briantu briantu force-pushed the brian.tu/host-hardware-mac branch from 55e7350 to 73e4595 Compare January 13, 2026 16:18
@briantu briantu marked this pull request as ready for review January 13, 2026 17:23
@briantu briantu requested review from a team as code owners January 13, 2026 17:23
@briantu briantu changed the title Collect Mac system hardware information [EUDM] Collect Mac system information Jan 13, 2026
@briantu briantu added ask-review Ask required teams to review this PR qa/done QA done before merge and regressions are covered by tests labels Jan 13, 2026
@briantu briantu force-pushed the brian.tu/host-hardware-mac branch from beaea19 to 88a01af Compare January 14, 2026 01:02
@github-actions github-actions bot added medium review PR review might take time long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 14, 2026
@briantu briantu requested a review from iglendd January 14, 2026 20:27
Base automatically changed from mrafi/host-hardware to main January 20, 2026 15:30
@briantu briantu requested a review from guohdd January 20, 2026 17:53
@briantu briantu force-pushed the brian.tu/host-hardware-mac branch from 2b81db0 to be0fa7e Compare January 20, 2026 22:14
@briantu
Copy link
Contributor Author

briantu commented Jan 20, 2026

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 20, 2026

View all feedbacks in Devflow UI.

2026-01-20 22:15:40 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2026-01-20 22:15:57 UTC ℹ️ Branch synced on Gitlab

Branch brian.tu/host-hardware-mac was out-of-sync on Gitlab - it has been resynced


2026-01-20 22:17:09 UTC ℹ️ Gitlab pipeline started

Started pipeline #91771153

@briantu
Copy link
Contributor Author

briantu commented Jan 21, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 21, 2026

View all feedbacks in Devflow UI.

2026-01-21 02:02:09 UTC ℹ️ Start processing command /merge


2026-01-21 02:02:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 58m (p90).


2026-01-21 02:19:19 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 47bfd7b into main Jan 21, 2026
654 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the brian.tu/host-hardware-mac branch January 21, 2026 02:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ask-review Ask required teams to review this PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants