config: support configuring jmxfetch status path #25214
Draft
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
facetoe
force-pushed
the
jmxfetch_status_path
branch
from
5e1b272 to
1872188
Compare
ogaca-dd
approved these changes
Apr 29, 2024
hestonhoffman
approved these changes
Apr 29, 2024
Contributor
hestonhoffman
left a comment
hestonhoffman
left a comment
There was a problem hiding this comment.
Small edit to release note
releasenotes/notes/Expose-JMXFetch-status-path-51d422f36330d076.yaml
Outdated
Show resolved
Hide resolved
Useful information is written in the status.yaml, for example if you are dropping metrics. Add a config option to allow configuring the jmxfetch status path from the DD agent.
facetoe
force-pushed
the
jmxfetch_status_path
branch
from
1872188 to
0255edd
Compare
Author
|
Hey guys, any idea when this will be merged? |
Author
|
nvm some failed tests |
Contributor
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful information is written in the status.yaml, for example if you are dropping metrics. Add a config option to allow configuring the jmxfetch status path from the DD agent.
What does this PR do?
Add a config option to allow configuring the jmxfetch status path from the DD agent.
Motivation
It is useful to be able to access this information without needing to run jmxfetch, for example to see if metrics are being dropped.
Possible Drawbacks / Trade-offs
None that I can think of.
Describe how to test/QA your changes
Just configuring "jmxfetch_status_path" in the config and restarting the unit should result in the status being written there.