-
Notifications
You must be signed in to change notification settings - Fork 1.4k
pkg/logs/processor: use custom marshaler for json payload message #44536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/logs/processor: use custom marshaler for json payload message #44536
Conversation
| type payload struct { | ||
| Message string `json:"message"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: use test payload type to parse message as string.
| Encode(msg *message.Message, hostname string) error | ||
| } | ||
|
|
||
| type ValidUtf8Bytes []byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: its unfortunate that #30924 exported jsonPayload type. Maybe this type could be unexported given it is only used as fmt.Stringer:
| fmt.Println(parsedMessage.Message) |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: b85aa53 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.41 | [-1.51, +4.33] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_memory | memory utilization | +1.68 | [+1.52, +1.83] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | +1.41 | [-1.51, +4.33] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.05 | [-0.43, +2.54] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.89 | [+0.83, +0.95] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.61 | [+0.57, +0.64] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.43 | [+0.27, +0.58] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.14 | [+0.10, +0.18] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.10 | [-0.12, +0.33] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.09 | [-0.30, +0.48] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.09 | [-0.28, +0.46] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.07 | [-0.09, +0.24] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.02 | [-0.11, +0.15] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.13, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.08, +0.08] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.01 | [-0.24, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.06, +0.03] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.45, +0.40] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.07 | [-0.13, -0.02] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.32 | [-0.37, -0.26] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.44 | [-0.63, -0.24] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.62 | [-0.70, -0.54] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.62 | [-0.72, -0.52] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.18 | [-1.38, -0.97] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 2d05196: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
Change jsonPayload Message field type to use encoding.TextMarshaler/TextUnmarshaler
to avoid allocation due to conversion of valid UTF-8 bytes to string in the common case.
```
goos: darwin
goarch: arm64
pkg: github.com/DataDog/datadog-agent/pkg/logs/processor
cpu: Apple M4 Max
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
JSONEncoder_Encode/valid-16 563.1n ± 17% 543.7n ± 12% -3.45% (p=0.009 n=10)
JSONEncoder_Encode/invalid-16 567.0n ± 1% 550.0n ± 1% -3.00% (p=0.000 n=10)
geomean 565.0n 546.8n -3.22%
│ HEAD~1 │ HEAD │
│ B/op │ B/op vs base │
JSONEncoder_Encode/valid-16 1.127Ki ± 0% 1.017Ki ± 0% -9.79% (p=0.000 n=10)
JSONEncoder_Encode/invalid-16 1.127Ki ± 0% 1.017Ki ± 0% -9.79% (p=0.000 n=10)
geomean 1.127Ki 1.017Ki -9.79%
│ HEAD~1 │ HEAD │
│ allocs/op │ allocs/op vs base │
JSONEncoder_Encode/valid-16 10.000 ± 0% 9.000 ± 0% -10.00% (p=0.000 n=10)
JSONEncoder_Encode/invalid-16 10.000 ± 0% 9.000 ± 0% -10.00% (p=0.000 n=10)
geomean 10.00 9.000 -10.00%
```
d0bb323 to
dfa206a
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Change jsonPayload Message field type to use encoding.TextMarshaler/TextUnmarshaler
to avoid allocation due to conversion of valid UTF-8 bytes to string in the common case.
Motivation
Reduce memory allocations.
Describe how you validated your changes
By introducing benchmark and comparing results before and after the change.
Additional Notes
Better review per commit. This is related to #33906