Skip to content

feat(network-path): add default filters for end_user_device mode#44757

Merged
dd-mergequeue[bot] merged 13 commits intomainfrom
louis-cqrl/add-network_path-defaults
Jan 16, 2026
Merged

feat(network-path): add default filters for end_user_device mode#44757
dd-mergequeue[bot] merged 13 commits intomainfrom
louis-cqrl/add-network_path-defaults

Conversation

@louis-cqrl
Copy link
Copy Markdown
Contributor

@louis-cqrl louis-cqrl commented Jan 5, 2026

What does this PR do?

Adds a default set of network path filters for end_user_device infrastructure mode and ensures filters are initialized as an empty slice by default.

Motivation

Provide safe, sensible defaults for network path collection on end-user devices while still allowing users to override or extend them.

Describe how you validated your changes

CI

QA steps

Additional Notes

User-defined filters are appended after defaults to ensure higher priority.

feat(config.go): Add exclusion check list parameter
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Jan 5, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b188b32
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +252.13 KiB (0.03% increase) 705.304 → 705.550 → 708.410
agent_deb_amd64_fips +264.13 KiB (0.04% increase) 700.582 → 700.840 → 704.000
agent_heroku_amd64 +72.23 KiB (0.02% increase) 326.960 → 327.030 → 329.530
agent_msi +256.23 KiB (0.04% increase) 571.579 → 571.829 → 982.080
agent_rpm_amd64 +252.13 KiB (0.03% increase) 705.291 → 705.537 → 708.380
agent_rpm_amd64_fips +264.13 KiB (0.04% increase) 700.568 → 700.826 → 703.990
agent_rpm_arm64 +195.75 KiB (0.03% increase) 686.859 → 687.050 → 693.520
agent_rpm_arm64_fips +227.75 KiB (0.03% increase) 682.965 → 683.187 → 688.480
agent_suse_amd64 +252.13 KiB (0.03% increase) 705.291 → 705.537 → 708.380
agent_suse_amd64_fips +264.13 KiB (0.04% increase) 700.568 → 700.826 → 703.990
agent_suse_arm64 +195.75 KiB (0.03% increase) 686.859 → 687.050 → 693.520
agent_suse_arm64_fips +227.75 KiB (0.03% increase) 682.965 → 683.187 → 688.480
docker_agent_amd64 +216.14 KiB (0.03% increase) 767.482 → 767.693 → 770.720
docker_agent_arm64 +195.75 KiB (0.02% increase) 773.630 → 773.821 → 780.200
docker_agent_jmx_amd64 +216.13 KiB (0.02% increase) 958.361 → 958.572 → 961.600
docker_agent_jmx_arm64 +195.75 KiB (0.02% increase) 953.228 → 953.419 → 959.800
docker_cluster_agent_amd64 +36.01 KiB (0.02% increase) 180.698 → 180.733 → 181.080
docker_cluster_agent_arm64 +64.01 KiB (0.03% increase) 196.540 → 196.602 → 198.490
docker_dogstatsd_amd64 +36.0 KiB (0.09% increase) 38.808 → 38.843 → 39.380
dogstatsd_deb_amd64 +36.0 KiB (0.12% increase) 30.031 → 30.066 → 30.610
dogstatsd_deb_arm64 +36.0 KiB (0.12% increase) 28.176 → 28.211 → 29.110
dogstatsd_rpm_amd64 +36.0 KiB (0.12% increase) 30.031 → 30.066 → 30.610
dogstatsd_suse_amd64 +36.0 KiB (0.12% increase) 30.031 → 30.066 → 30.610
iot_agent_deb_amd64 +36.0 KiB (0.08% increase) 43.065 → 43.100 → 43.290
iot_agent_deb_arm64 +36.0 KiB (0.09% increase) 40.178 → 40.214 → 40.920
iot_agent_deb_armhf +36.0 KiB (0.09% increase) 40.763 → 40.798 → 41.030
iot_agent_rpm_amd64 +36.0 KiB (0.08% increase) 43.066 → 43.101 → 43.290
iot_agent_suse_amd64 +36.0 KiB (0.08% increase) 43.066 → 43.101 → 43.290
3 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_arm64 37.128 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +39.05 KiB (0.02% increase) 173.305 → 173.343 → 174.490
agent_deb_amd64_fips +37.06 KiB (0.02% increase) 172.277 → 172.313 → 173.750
agent_heroku_amd64 +13.88 KiB (0.02% increase) 87.121 → 87.135 → 88.450
agent_msi +56.0 KiB (0.04% increase) 142.941 → 142.996 → 143.020
agent_rpm_amd64 -111.68 KiB (0.06% reduction) 176.133 → 176.024 → 177.660
agent_rpm_amd64_fips +127.43 KiB (0.07% increase) 174.967 → 175.092 → 176.600
agent_rpm_arm64 +36.32 KiB (0.02% increase) 159.360 → 159.395 → 161.260
agent_rpm_arm64_fips -84.79 KiB (0.05% reduction) 158.769 → 158.686 → 160.550
agent_suse_amd64 -111.68 KiB (0.06% reduction) 176.133 → 176.024 → 177.660
agent_suse_amd64_fips +127.43 KiB (0.07% increase) 174.967 → 175.092 → 176.600
agent_suse_arm64 +36.32 KiB (0.02% increase) 159.360 → 159.395 → 161.260
agent_suse_arm64_fips -84.79 KiB (0.05% reduction) 158.769 → 158.686 → 160.550
docker_agent_amd64 +60.57 KiB (0.02% increase) 261.065 → 261.124 → 262.450
docker_agent_arm64 +37.82 KiB (0.01% increase) 250.086 → 250.123 → 252.630
docker_agent_jmx_amd64 +58.25 KiB (0.02% increase) 329.705 → 329.762 → 331.080
docker_agent_jmx_arm64 +35.24 KiB (0.01% increase) 314.709 → 314.744 → 317.270
docker_cluster_agent_amd64 +2.36 KiB (0.00% increase) 63.848 → 63.850 → 64.490
docker_cluster_agent_arm64 +5.65 KiB (0.01% increase) 60.126 → 60.131 → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 +12.11 KiB (0.08% increase) 15.026 → 15.038 → 15.820
docker_dogstatsd_arm64 +11.72 KiB (0.08% increase) 14.351 → 14.362 → 14.830
dogstatsd_deb_amd64 +5.5 KiB (0.07% increase) 7.945 → 7.951 → 8.790
dogstatsd_deb_arm64 +2.87 KiB (0.04% increase) 6.822 → 6.825 → 7.710
dogstatsd_rpm_amd64 +6.35 KiB (0.08% increase) 7.956 → 7.962 → 8.800
dogstatsd_suse_amd64 +6.35 KiB (0.08% increase) 7.956 → 7.962 → 8.800
iot_agent_deb_amd64 +5.07 KiB (0.04% increase) 11.288 → 11.293 → 12.040
iot_agent_deb_arm64 +5.69 KiB (0.06% increase) 9.649 → 9.654 → 10.450
iot_agent_deb_armhf +5.89 KiB (0.06% increase) 9.844 → 9.850 → 10.620
iot_agent_rpm_amd64 +4.99 KiB (0.04% increase) 11.305 → 11.310 → 12.060
iot_agent_suse_amd64 +4.99 KiB (0.04% increase) 11.305 → 11.310 → 12.060

@cit-pr-commenter
Copy link
Copy Markdown

cit-pr-commenter bot commented Jan 5, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9c1c5dd0-2766-48d6-97cf-67ff79615c15

Baseline: b188b32
Comparison: 5b4ad20
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +5.81 [+2.76, +8.86] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +5.81 [+2.76, +8.86] 1 Logs
quality_gate_logs % cpu utilization +1.51 [+0.04, +2.97] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.96 [+0.87, +1.06] 1 Logs
ddot_logs memory utilization +0.78 [+0.72, +0.83] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.57 [+0.52, +0.63] 1 Logs
docker_containers_memory memory utilization +0.52 [+0.45, +0.59] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.48 [+0.26, +0.71] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.48 [+0.33, +0.64] 1 Logs
ddot_metrics_sum_delta memory utilization +0.48 [+0.28, +0.68] 1 Logs
quality_gate_idle_all_features memory utilization +0.42 [+0.38, +0.46] 1 Logs bounds checks dashboard
file_tree memory utilization +0.07 [+0.02, +0.13] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.45, +0.54] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.03 [-0.06, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.03, +0.06] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.08, +0.10] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.13, +0.14] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.13, +0.12] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.43, +0.42] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.41, +0.36] 1 Logs
quality_gate_idle memory utilization -0.08 [-0.12, -0.03] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.33 [-0.48, -0.18] 1 Logs
quality_gate_metrics_logs memory utilization -0.35 [-0.55, -0.14] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.84 [-1.06, -0.62] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 11 (x3) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 11 (x3) Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@louis-cqrl louis-cqrl changed the title Add network path filters by default feat(network-path): add default filters for end_user_device mode Jan 6, 2026
add default in config template
@louis-cqrl louis-cqrl force-pushed the louis-cqrl/add-network_path-defaults branch from a4b52ea to 7abe3f8 Compare January 6, 2026 10:53
@louis-cqrl louis-cqrl requested a review from a team January 8, 2026 14:39
@louis-cqrl louis-cqrl marked this pull request as ready for review January 8, 2026 14:39
@louis-cqrl louis-cqrl requested review from a team as code owners January 8, 2026 14:39
@louis-cqrl louis-cqrl requested review from iglendd, pimlu and s-alad and removed request for a team January 8, 2026 14:39
@louis-cqrl louis-cqrl added changelog/no-changelog No changelog entry needed qa/rc-required Only for a PR that requires validation on the Release Candidate team/windows-products labels Jan 8, 2026
@drichards-87 drichards-87 self-assigned this Jan 8, 2026
@drichards-87 drichards-87 removed their assignment Jan 8, 2026
@louis-cqrl louis-cqrl added the ask-review Ask required teams to review this PR label Jan 9, 2026
@louis-cqrl louis-cqrl requested a review from fabbing January 9, 2026 09:54
@github-actions github-actions bot added the medium review PR review might take time label Jan 12, 2026
Copy link
Copy Markdown
Contributor

@ken-schneider ken-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Alex's comment above about moving the list elsewhere

Base automatically changed from louis-cqrl/add-allowlist-logic-for-infra-mode to main January 14, 2026 16:35
@dd-mergequeue dd-mergequeue bot requested a review from a team as a code owner January 14, 2026 16:35
@dd-mergequeue dd-mergequeue bot requested a review from pgimalac January 14, 2026 16:35
@louis-cqrl louis-cqrl removed the request for review from pgimalac January 16, 2026 09:18
@louis-cqrl
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Jan 16, 2026

View all feedbacks in Devflow UI.

2026-01-16 10:05:24 UTC ℹ️ Start processing command /merge


2026-01-16 10:05:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-16 11:05:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 58m (p90).


2026-01-16 11:47:27 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c2cf39d into main Jan 16, 2026
338 checks passed
@dd-mergequeue dd-mergequeue bot deleted the louis-cqrl/add-network_path-defaults branch January 16, 2026 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed medium review PR review might take time qa/rc-required Only for a PR that requires validation on the Release Candidate team/network-path

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants