[SQG] Add missing expression attribute#45124
Conversation
JSGette
added
changelog/no-changelog
github-actions
bot
added
team/agent-build
short review
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ccd903c Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | docker_containers_cpu | % cpu utilization | +5.24 | [+2.20, +8.28] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | docker_containers_cpu | % cpu utilization | +5.24 | [+2.20, +8.28] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.93 | [+0.73, +1.13] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.46 | [+0.31, +0.61] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.44 | [+0.40, +0.47] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.44 | [+0.37, +0.51] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.03 | [-0.10, +0.16] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.02, +0.07] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.38, +0.43] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.38, +0.39] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.14, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.04 | [-0.56, +0.48] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.04 | [-0.08, +0.00] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.04 | [-0.20, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.06 | [-0.12, -0.01] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.06 | [-0.17, +0.04] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.11 | [-0.33, +0.10] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -0.14 | [-0.21, -0.07] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.28 | [-0.34, -0.22] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.36 | [-0.59, -0.13] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.37 | [-0.58, -0.16] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.93 | [-1.00, -0.86] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.67 | [-3.11, -0.22] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Replicate Execution Details
We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.
Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.
| Experiment | Variant | Replicates | Failure | Logs | Debug Dashboard |
|---|---|---|---|---|---|
| experiment_with_failures | baseline | 0 (x8) 1 (x6) | Oom killed | Debug Dashboard |
The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.
❌ Retried Profiling Replicate Execution Failures (target internal profiling)
Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle_all_features | baseline | 11 (x4) | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 11 (x2) | Oom killed | Debug Dashboard |
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
github-actions
bot
added
medium review
Add missing expression attribute & simplify logic
JSGette
force-pushed
the
jsgette/sqg_fix_new_bump_task
branch
from
71639cb to
10102fc
Compare
github-actions
bot
added
short review
JSGette
changed the title
JSGette
changed the title
| for point in reversed(pointlist): | ||
| if point and len(point) >= 2 and point[1] is not None: | ||
| return point[1] | ||
| if point and point.value and point.value[1] is not None: |
There was a problem hiding this comment.
This is a little bit weird but just to avoid the situation when metric point was indeed reported but with empty value. First (0) element of the value is a timestamp when the metric was reported that's why it's important to check the second element (1)
JSGette
added
ask-review
JSGette
changed the title
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for d9961e5: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
### What does this PR do? This fixes a newly introduced SQG bump task that was always reporting no failing gates to bump. The issue was in lack of `expression` attribute that is crucial to determine which metric we want to use. Also, instead of heavily relying on Reflection API we now use attributes directly which makes the code cleaner and easier to read and maintain. ### Describe how you validated your changes 1. I have reduced the maximum for one of the gates. 2. Waited the pipeline to complete (so that SQG job reports the results) 3. Ran `dd-auth -- dda inv quality-gates.exception-threshold-bump 45124` to see that failing gate was bumped: ```shell Fetching metrics for PR #45124... Found metrics for 31 gates Found 1 failing gates: - agent_deb_amd64: disk +4.86 MiB, wire +-1.18 MiB Fetching main branch metrics for headroom calculation... [SUCCESS] Updated 1 gate thresholds: - agent_deb_amd64: disk: 700.41 MiB → 708.41 MiB - agent_deb_amd64: wire: 174.49 MiB → 174.49 MiB ``` 4. Verified that `static_quality_gates.yml` contained unstaged changes. ### Additional Notes This task doesn't work with pipelines anymore. Instead, it relies on Datadog and reported metrics meaning that if a PR doesn't have a run of SQG job and metrics weren't uploaded in the last 24 hours the task will fail. This is to ensure that PR is as close to the current state of the main branch as possible to improve accuracy of the size calculation. Co-authored-by: joseph.gette <joseph.gette@datadoghq.com>
3 participants
What does this PR do?
This fixes a newly introduced SQG bump task that was always reporting no failing gates to bump. The issue was in lack of
expressionattribute that is crucial to determine which metric we want to use. Also, instead of heavily relying on Reflection API we now use attributes directly which makes the code cleaner and easier to read and maintain.Describe how you validated your changes
dd-auth -- dda inv quality-gates.exception-threshold-bump 45124to see that failing gate was bumped:
static_quality_gates.ymlcontained unstaged changes.Additional Notes
This task doesn't work with pipelines anymore. Instead, it relies on Datadog and reported metrics meaning that if a PR doesn't have a run of SQG job and metrics weren't uploaded in the last 24 hours the task will fail. This is to ensure that PR is as close to the current state of the main branch as possible to improve accuracy of the size calculation.