Skip to content

Reapply "feat(review): Automatically call for review when a PR become…#45126

Merged
dd-mergequeue[bot] merged 2 commits intomainfrom
nschweitzer/review
Jan 15, 2026
Merged

Reapply "feat(review): Automatically call for review when a PR become…#45126
dd-mergequeue[bot] merged 2 commits intomainfrom
nschweitzer/review

Conversation

@chouetz
Copy link
Copy Markdown
Member

@chouetz chouetz commented Jan 15, 2026

…s ready_for_review or review_requested" (#45125)

This reverts commit 78bc8cd.

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

…s ready_for_review or review_requested" (#45125)

This reverts commit 78bc8cd.
@github-actions github-actions bot added medium review PR review might take time team/agent-devx labels Jan 15, 2026
@chouetz chouetz marked this pull request as ready for review January 15, 2026 09:55
@chouetz chouetz requested a review from a team as a code owner January 15, 2026 09:55
@chouetz chouetz marked this pull request as draft January 15, 2026 09:57
@chouetz chouetz marked this pull request as ready for review January 15, 2026 09:58
@chouetz chouetz added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Jan 15, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 78bc8cd
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 705.269 MiB
agent_deb_amd64_fips 700.554 MiB
agent_heroku_amd64 326.908 MiB
agent_msi 571.532 MiB
agent_rpm_amd64 705.256 MiB
agent_rpm_amd64_fips 700.541 MiB
agent_rpm_arm64 686.832 MiB
agent_rpm_arm64_fips 682.941 MiB
agent_suse_amd64 705.256 MiB
agent_suse_amd64_fips 700.541 MiB
agent_suse_arm64 686.832 MiB
agent_suse_arm64_fips 682.941 MiB
docker_agent_amd64 767.464 MiB
docker_agent_arm64 773.619 MiB
docker_agent_jmx_amd64 958.343 MiB
docker_agent_jmx_arm64 953.217 MiB
docker_cluster_agent_amd64 180.684 MiB
docker_cluster_agent_arm64 196.557 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.808 MiB
docker_dogstatsd_arm64 37.128 MiB
dogstatsd_deb_amd64 30.027 MiB
dogstatsd_deb_arm64 28.176 MiB
dogstatsd_rpm_amd64 30.027 MiB
dogstatsd_suse_amd64 30.027 MiB
iot_agent_deb_amd64 42.983 MiB
iot_agent_deb_arm64 40.108 MiB
iot_agent_deb_armhf 40.685 MiB
iot_agent_rpm_amd64 42.983 MiB
iot_agent_suse_amd64 42.983 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -42.47 KiB (0.02% reduction) 173.361 → 173.320 → 174.490
agent_deb_amd64_fips +21.27 KiB (0.01% increase) 172.270 → 172.291 → 173.750
agent_heroku_amd64 -3.08 KiB (0.00% reduction) 87.106 → 87.103 → 88.450
agent_msi +28.0 KiB (0.02% increase) 142.902 → 142.930 → 143.020
agent_rpm_amd64 -19.53 KiB (0.01% reduction) 176.128 → 176.109 → 177.660
agent_rpm_amd64_fips -30.68 KiB (0.02% reduction) 174.964 → 174.934 → 176.600
agent_rpm_arm64 -39.59 KiB (0.02% reduction) 159.382 → 159.343 → 161.260
agent_rpm_arm64_fips -17.44 KiB (0.01% reduction) 158.786 → 158.769 → 160.550
agent_suse_amd64 -19.53 KiB (0.01% reduction) 176.128 → 176.109 → 177.660
agent_suse_amd64_fips -30.68 KiB (0.02% reduction) 174.964 → 174.934 → 176.600
agent_suse_arm64 -39.59 KiB (0.02% reduction) 159.382 → 159.343 → 161.260
agent_suse_arm64_fips -17.44 KiB (0.01% reduction) 158.786 → 158.769 → 160.550
docker_agent_amd64 neutral 261.029 MiB
docker_agent_arm64 neutral 250.048 MiB
docker_agent_jmx_amd64 neutral 329.668 MiB
docker_agent_jmx_arm64 -2.3 KiB (0.00% reduction) 314.684 → 314.681 → 317.270
docker_cluster_agent_amd64 neutral 63.830 MiB
docker_cluster_agent_arm64 neutral 60.124 MiB
docker_cws_instrumentation_amd64 neutral 2.994 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 neutral 15.025 MiB
docker_dogstatsd_arm64 neutral 14.354 MiB
dogstatsd_deb_amd64 neutral 7.944 MiB
dogstatsd_deb_arm64 neutral 6.823 MiB
dogstatsd_rpm_amd64 neutral 7.955 MiB
dogstatsd_suse_amd64 neutral 7.955 MiB
iot_agent_deb_amd64 neutral 11.260 MiB
iot_agent_deb_arm64 +2.45 KiB (0.02% increase) 9.630 → 9.633 → 10.450
iot_agent_deb_armhf neutral 9.822 MiB
iot_agent_rpm_amd64 neutral 11.274 MiB
iot_agent_suse_amd64 neutral 11.274 MiB

@cit-pr-commenter
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 75c10a7c-4f9e-4300-863f-ef45a067477c

Baseline: edf14f6
Comparison: 5caa251
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +5.64 [+2.57, +8.71] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +5.64 [+2.57, +8.71] 1 Logs
quality_gate_logs % cpu utilization +1.15 [-0.33, +2.64] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.74 [+0.54, +0.93] 1 Logs
ddot_logs memory utilization +0.61 [+0.55, +0.67] 1 Logs
ddot_metrics memory utilization +0.59 [+0.34, +0.83] 1 Logs
otlp_ingest_logs memory utilization +0.47 [+0.38, +0.56] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.39 [+0.23, +0.55] 1 Logs
quality_gate_idle memory utilization +0.20 [+0.16, +0.25] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.18 [+0.02, +0.34] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.01, +0.09] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.48, +0.49] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.10, +0.09] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.12] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.41, +0.38] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.02 [-0.10, +0.07] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.45, +0.40] 1 Logs
quality_gate_metrics_logs memory utilization -0.22 [-0.44, +0.00] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.30 [-0.33, -0.26] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.34 [-0.40, -0.29] 1 Logs
file_tree memory utilization -0.36 [-0.41, -0.30] 1 Logs
docker_containers_memory memory utilization -0.49 [-0.56, -0.42] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.52 [-0.75, -0.29] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 11 (x4) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 11 (x4) Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@chouetz
Copy link
Copy Markdown
Member Author

chouetz commented Jan 15, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Jan 15, 2026

View all feedbacks in Devflow UI.

2026-01-15 16:44:42 UTC ℹ️ Start processing command /merge


2026-01-15 16:45:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 60m (p90).


2026-01-15 17:20:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 661612b into main Jan 15, 2026
296 of 297 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/review branch January 15, 2026 17:20
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 15, 2026
chouetz added a commit that referenced this pull request Jan 16, 2026
theomagellan pushed a commit that referenced this pull request Jan 19, 2026
#45126)

…s ready_for_review or review_requested" (#45125)

This reverts commit 78bc8cd.

### What does this PR do?

### Motivation

### Describe how you validated your changes

### Additional Notes


Co-authored-by: nicolas.schweitzer <nicolas.schweitzer@datadoghq.com>
theomagellan pushed a commit that referenced this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants