Fix bazel:mod-tidy job to ignore lockfile changes#45129
Conversation
The `bazel:mod-tidy` job is meant to ensure `MODULE.bazel` remains in an optimal state (not only in `bazel`'s opinionated format, but also to help maintain the `use_repo` directives that Gazelle will update). The problem is that I added it without thinking it could fail due to `MODULE.bazel.lock` being updated by side effect, which is already (and better) guarded by the sibling `bazel:mod-deps` job. Adding `--lockfile_mode=off` to `bazel mod tidy` is therefore meant to prevent `bazel:mod-tidy` from failing on lockfile changes for a proper separation of concerns, distinct hints being provided.
Gitlab CI Configuration ChangesModified Jobsbazel:mod-tidy bazel:mod-tidy:
after_script:
- "if [ $CI_JOB_STATUS = failed ]; then\n echo >&2 \"\U0001F4A1 bazel mod tidy\"\
\nfi"
needs: []
script:
- - bazel mod tidy
+ - bazel mod tidy --lockfile_mode=off
- git diff --exit-code
stage: lint
tags:
- k8s-persistent:amd64
- specific:true
variables:
BAZELISK_HOME: $XDG_CACHE_HOME/bazelisk
XDG_CACHE_HOME: /data/bzlChanges Summary
ℹ️ Diff available in the job log. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
Build pipeline has failing jobs for c754605: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: adbf998 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.00 | [-3.96, +1.96] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +1.22 | [-0.24, +2.69] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.90 | [+0.68, +1.12] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.46 | [+0.28, +0.63] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.35 | [+0.31, +0.39] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.23 | [+0.00, +0.46] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.33, +0.43] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.13, +0.14] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.13, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.52, +0.51] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.43, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.10, -0.01] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.09 | [-0.16, -0.03] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.17 | [-0.24, -0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.18 | [-0.23, -0.12] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.25 | [-0.31, -0.19] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.32 | [-0.41, -0.22] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.33 | [-0.37, -0.29] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.38 | [-0.59, -0.17] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.49 | [-0.64, -0.34] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.59 | [-0.81, -0.37] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -1.00 | [-3.96, +1.96] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.60 | [-1.69, -1.52] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Replicate Execution Details
We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.
Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.
| Experiment | Variant | Replicates | Failure | Logs | Debug Dashboard |
|---|---|---|---|---|---|
| experiment_with_failures | baseline | 0 (x8) 1 (x6) | Oom killed | Debug Dashboard |
The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.
❌ Retried Profiling Replicate Execution Failures (target internal profiling)
Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle_all_features | baseline | 11 (x4) | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 11 (x3) | Oom killed | Debug Dashboard |
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
### Motivation The `bazel:mod-tidy` job is meant to ensure `MODULE.bazel` remains in an optimal state (not only in `bazel`'s opinionated format, but first and foremost to help maintain the `use_repo` directives that Gazelle will update). The problem is that I added it without thinking it could fail due to `MODULE.bazel.lock` being updated by side effect, which is already (and better) guarded by the sibling `bazel:mod-deps` job, misleadingly causing [both to fail](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/90857566) on inadvertent changes in the lockfile: <img width="337" height="159" alt="image" src="https://github.com/user-attachments/assets/c6a3f998-29ef-4286-a561-2a48f3555a61" /> ### What does this PR do? Adding `--lockfile_mode=off` to `bazel mod tidy` is therefore meant to prevent `bazel:mod-tidy` from failing on lockfile changes for a proper separation of concerns, distinct hints being provided: ```diff -💡 bazel mod tidy +💡 bazel mod deps ```
Motivation
The
bazel:mod-tidyjob is meant to ensureMODULE.bazelremains in an optimal state (not only inbazel's opinionated format, but first and foremost to help maintain theuse_repodirectives that Gazelle will update).The problem is that I added it without thinking it could fail due to

MODULE.bazel.lockbeing updated by side effect, which is already (and better) guarded by the siblingbazel:mod-depsjob, misleadingly causing both to fail on inadvertent changes in the lockfile:What does this PR do?
Adding
--lockfile_mode=offtobazel mod tidyis therefore meant to preventbazel:mod-tidyfrom failing on lockfile changes for a proper separation of concerns, distinct hints being provided: