Skip to content

[SBOM] Add remote SBOM collector to compute package usage#46219

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 46 commits intomainfrom
lebauce/running-container-sbom-v2
Mar 20, 2026
Merged

[SBOM] Add remote SBOM collector to compute package usage#46219
gh-worker-dd-mergequeue-cf854d[bot] merged 46 commits intomainfrom
lebauce/running-container-sbom-v2

Conversation

@lebauce
Copy link
Contributor

@lebauce lebauce commented Feb 10, 2026

What does this PR do?

  • Forward container images from the core agent to system-probe through remote workload meta
  • Introduce a remote SBOM collector so that the core agent can receive enriched SBOM from system-probe
  • Keep track of package last access and use it to enrich SBOM with a LastSeenRunning, HasSetSuidBit and RunningAsRoot.
  • Compute internal policies for SBOM computed by system-probe

Motivation

This allow prioritization of vulnerabilities based on their actual usage.

Describe how you validated your changes

  • Enable the feature
  • Pull some docker images
  • Generate a flare and check the SBOM for these images
  • Start containers using these images
  • Generate a flare
  • Check that the LastSeenRunning property is set for the right components

Additional Notes

@lebauce lebauce requested review from a team as code owners February 10, 2026 20:27
@lebauce lebauce requested a review from nathan-b February 10, 2026 20:27
@lebauce lebauce marked this pull request as draft February 10, 2026 20:27
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 10, 2026

Go Package Import Differences

Baseline: 0887c75
Comparison: 8bddfe6

binaryosarchchange
agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/pkg/proto/pbgo/sbom
+github.com/golang/protobuf/proto
agentlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/pkg/proto/pbgo/sbom
+github.com/golang/protobuf/proto
security-agentwindowsamd64
+1, -0
+os/user
system-probelinuxamd64
+9, -0
+github.com/DataDog/datadog-agent/pkg/proto/pbgo/sbom
+github.com/DataDog/datadog-agent/pkg/sbom
+github.com/DataDog/datadog-agent/pkg/sbom/types
+github.com/containerd/containerd/protobuf/proto
+github.com/samber/lo
+github.com/samber/lo/mutable
+golang.org/x/text/cases
+golang.org/x/text/internal
+golang.org/x/text/language
system-probelinuxarm64
+9, -0
+github.com/DataDog/datadog-agent/pkg/proto/pbgo/sbom
+github.com/DataDog/datadog-agent/pkg/sbom
+github.com/DataDog/datadog-agent/pkg/sbom/types
+github.com/containerd/containerd/protobuf/proto
+github.com/samber/lo
+github.com/samber/lo/mutable
+golang.org/x/text/cases
+golang.org/x/text/internal
+golang.org/x/text/language
system-probewindowsamd64
+3, -0
+github.com/DataDog/datadog-agent/pkg/proto/pbgo/sbom
+github.com/DataDog/datadog-agent/pkg/sbom
+github.com/DataDog/datadog-agent/pkg/sbom/types

@nathan-b
Copy link
Contributor

Once this PR moves out of draft (or before), please fill out the change description to help your reviewers understand what you are doing and why 😀

@lebauce lebauce force-pushed the lebauce/running-container-sbom-v2 branch 3 times, most recently from 13b48a9 to 9131d1c Compare February 13, 2026 09:10
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Feb 13, 2026
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 13, 2026
@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Feb 13, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 78047156-775a-422a-9d98-6c15ec251636

Baseline: a186947
Comparison: 20aa50f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.25 [-2.79, +3.29] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.81 [+1.57, +2.05] 1 Logs bounds checks dashboard
file_tree memory utilization +0.66 [+0.60, +0.71] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.63 [+0.48, +0.77] 1 Logs
quality_gate_logs % cpu utilization +0.60 [-1.01, +2.20] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.40 [+0.22, +0.58] 1 Logs
quality_gate_idle memory utilization +0.39 [+0.34, +0.44] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.35 [+0.19, +0.51] 1 Logs
quality_gate_idle_all_features memory utilization +0.33 [+0.29, +0.37] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.32 [+0.26, +0.39] 1 Logs
docker_containers_cpu % cpu utilization +0.25 [-2.79, +3.29] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.13 [-0.10, +0.35] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.07, +0.07] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.11, +0.10] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.22, +0.21] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.21, +0.20] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.55, +0.49] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.06 [-0.48, +0.36] 1 Logs
ddot_metrics_sum_delta memory utilization -0.09 [-0.26, +0.08] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.14 [-0.53, +0.24] 1 Logs
docker_containers_memory memory utilization -0.21 [-0.29, -0.14] 1 Logs
otlp_ingest_logs memory utilization -0.64 [-0.75, -0.53] 1 Logs
ddot_logs memory utilization -0.68 [-0.75, -0.62] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.04 [-1.18, -0.90] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 684 ≥ 26
docker_containers_memory memory_usage 10/10 276.61MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 693 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.57MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 492.65MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 205.30MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 353.49 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 426.21MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@lebauce lebauce force-pushed the lebauce/running-container-sbom-v2 branch from f30f9ea to 725792a Compare February 16, 2026 16:25
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 16, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0887c75
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +467.47 KiB (0.06% increase) 750.699 → 751.155 → 753.380
agent_deb_amd64_fips +459.29 KiB (0.06% increase) 707.631 → 708.079 → 713.900
agent_heroku_amd64 +24.22 KiB (0.01% increase) 313.003 → 313.027 → 320.580
agent_msi +237.5 KiB (0.04% increase) 604.238 → 604.470 → 1062.520
agent_rpm_amd64 +467.47 KiB (0.06% increase) 750.682 → 751.139 → 753.350
agent_rpm_amd64_fips +459.29 KiB (0.06% increase) 707.614 → 708.063 → 713.880
agent_rpm_arm64 +487.2 KiB (0.07% increase) 729.016 → 729.491 → 735.290
agent_rpm_arm64_fips +435.07 KiB (0.06% increase) 689.008 → 689.432 → 696.840
agent_suse_amd64 +467.47 KiB (0.06% increase) 750.682 → 751.139 → 753.350
agent_suse_amd64_fips +459.29 KiB (0.06% increase) 707.614 → 708.063 → 713.880
agent_suse_arm64 +487.2 KiB (0.07% increase) 729.016 → 729.491 → 735.290
agent_suse_arm64_fips +435.07 KiB (0.06% increase) 689.008 → 689.432 → 696.840
docker_agent_amd64 +455.38 KiB (0.05% increase) 811.017 → 811.462 → 815.700
docker_agent_arm64 +423.1 KiB (0.05% increase) 814.164 → 814.577 → 821.970
docker_agent_jmx_amd64 +455.38 KiB (0.04% increase) 1001.933 → 1002.378 → 1006.580
docker_agent_jmx_arm64 +423.1 KiB (0.04% increase) 993.858 → 994.271 → 1001.570
docker_cluster_agent_amd64 +12.12 KiB (0.01% increase) 205.292 → 205.304 → 206.270
docker_cluster_agent_arm64 +64.08 KiB (0.03% increase) 219.614 → 219.677 → 220.000
docker_dogstatsd_amd64 +8.09 KiB (0.02% increase) 39.215 → 39.223 → 39.380
dogstatsd_deb_amd64 +12.09 KiB (0.04% increase) 29.855 → 29.866 → 30.610
dogstatsd_deb_arm64 +12.09 KiB (0.04% increase) 28.007 → 28.019 → 29.110
dogstatsd_rpm_amd64 +12.09 KiB (0.04% increase) 29.855 → 29.866 → 30.610
dogstatsd_suse_amd64 +12.09 KiB (0.04% increase) 29.855 → 29.866 → 30.610
iot_agent_deb_amd64 +20.12 KiB (0.05% increase) 43.218 → 43.238 → 43.290
iot_agent_deb_arm64 +16.12 KiB (0.04% increase) 40.273 → 40.289 → 40.920
iot_agent_deb_armhf +16.07 KiB (0.04% increase) 41.017 → 41.032 → 41.100
iot_agent_rpm_amd64 +20.12 KiB (0.05% increase) 43.219 → 43.238 → 43.290
iot_agent_suse_amd64 +20.12 KiB (0.05% increase) 43.219 → 43.238 → 43.290
3 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_arm64 37.445 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +51.3 KiB (0.03% increase) 174.717 → 174.767 → 178.360
agent_deb_amd64_fips +118.58 KiB (0.07% increase) 165.249 → 165.365 → 172.790
agent_heroku_amd64 +12.91 KiB (0.02% increase) 74.942 → 74.955 → 79.970
agent_msi +92.0 KiB (0.06% increase) 138.230 → 138.320 → 146.220
agent_rpm_amd64 -3.56 KiB (0.00% reduction) 177.609 → 177.606 → 181.830
agent_rpm_amd64_fips +220.07 KiB (0.13% increase) 167.310 → 167.524 → 173.370
agent_rpm_arm64 -10.62 KiB (0.01% reduction) 159.549 → 159.538 → 163.060
agent_rpm_arm64_fips +84.68 KiB (0.05% increase) 151.267 → 151.350 → 156.170
agent_suse_amd64 -3.56 KiB (0.00% reduction) 177.609 → 177.606 → 181.830
agent_suse_amd64_fips +220.07 KiB (0.13% increase) 167.310 → 167.524 → 173.370
agent_suse_arm64 -10.62 KiB (0.01% reduction) 159.549 → 159.538 → 163.060
agent_suse_arm64_fips +84.68 KiB (0.05% increase) 151.267 → 151.350 → 156.170
docker_agent_amd64 +152.19 KiB (0.06% increase) 267.883 → 268.031 → 272.480
docker_agent_arm64 +164.44 KiB (0.06% increase) 255.085 → 255.246 → 261.060
docker_agent_jmx_amd64 +155.69 KiB (0.05% increase) 336.529 → 336.681 → 341.100
docker_agent_jmx_arm64 +155.47 KiB (0.05% increase) 319.726 → 319.878 → 325.620
docker_cluster_agent_amd64 +3.79 KiB (0.01% increase) 71.921 → 71.925 → 72.920
docker_cluster_agent_arm64 -3.04 KiB (0.00% reduction) 67.506 → 67.503 → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 +7.12 KiB (0.05% increase) 15.161 → 15.168 → 15.820
docker_dogstatsd_arm64 +2.66 KiB (0.02% increase) 14.480 → 14.483 → 14.830
dogstatsd_deb_amd64 neutral 7.887 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.775 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.900 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.900 MiB → 8.800
iot_agent_deb_amd64 +4.09 KiB (0.04% increase) 11.385 → 11.389 → 12.040
iot_agent_deb_arm64 +5.39 KiB (0.05% increase) 9.692 → 9.697 → 10.450
iot_agent_deb_armhf +3.56 KiB (0.04% increase) 9.928 → 9.932 → 10.620
iot_agent_rpm_amd64 +3.0 KiB (0.03% increase) 11.403 → 11.406 → 12.060
iot_agent_suse_amd64 +3.0 KiB (0.03% increase) 11.403 → 11.406 → 12.060

@lebauce lebauce force-pushed the lebauce/running-container-sbom-v2 branch from 725792a to ad0b789 Compare February 17, 2026 12:51
@lebauce lebauce added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Feb 17, 2026
@lebauce lebauce marked this pull request as ready for review February 18, 2026 10:59
@lebauce lebauce requested a review from a team as a code owner February 18, 2026 10:59
@lebauce lebauce requested a review from a team as a code owner February 18, 2026 13:59
@lebauce lebauce requested a review from dustmop February 18, 2026 13:59
@lebauce lebauce force-pushed the lebauce/running-container-sbom-v2 branch from 2fdadb8 to e7bbd89 Compare March 20, 2026 13:25
@lebauce lebauce requested review from a team, cmourot and dd-ddamien as code owners March 20, 2026 15:38
Copy link

@dd-ddamien dd-ddamien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception approved for the IOT Agent.

@lebauce lebauce force-pushed the lebauce/running-container-sbom-v2 branch from 528f79d to 8bddfe6 Compare March 20, 2026 16:23
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 20aa50f into main Mar 20, 2026
426 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the lebauce/running-container-sbom-v2 branch March 20, 2026 19:14
@github-actions github-actions bot added this to the 7.79.0 milestone Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.