Re-enable datadog_otel_components_ocb_build with new rules#46641
Re-enable datadog_otel_components_ocb_build with new rules#46641gh-worker-dd-mergequeue-cf854d[bot] merged 11 commits intomainfrom
datadog_otel_components_ocb_build with new rules#46641Conversation
Re-enable the previously disabled `datadog_otel_components_ocb_build` integration test job and add a new `.on_otel_components_changes` rule anchor so the job runs on main merges and when otel component files change.
Gitlab CI Configuration ChangesAdded Jobs.on_otel_components_changes.on_otel_components_changes:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- if: $CI_COMMIT_BRANCH == "main"
- changes:
compare_to: $COMPARE_TO_BRANCH
paths:
- cmd/otel-agent/**/*
- comp/otelcol/**/*
- test/otel/testdata/**/*
when: on_successdatadog_otel_components_ocb_builddatadog_otel_components_ocb_build:
artifacts:
paths:
- ocb-output.log
- otelcol-custom.log
- flare-info.log
when: always
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache.tar.xz
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
needs:
- go_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- if: $CI_COMMIT_BRANCH == "main"
- changes:
compare_to: $COMPARE_TO_BRANCH
paths:
- cmd/otel-agent/**/*
- comp/otelcol/**/*
- test/otel/testdata/**/*
when: on_success
script:
- echo "Building custom collector with datadog components"
- test/otel/testdata/ocb_build_script.sh
- echo "see artifacts for job logs"
stage: integration_test
tags:
- arch:amd64
- specific:true
timeout: 15 minutes
variables:
KUBERNETES_CPU_REQUEST: 16
KUBERNETES_MEMORY_LIMIT: 32Gi
KUBERNETES_MEMORY_REQUEST: 32GiChanges Summary
ℹ️ Diff available in the job log. |
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 715b9fb Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -2.91 | [-5.93, +0.12] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +0.79 | [+0.57, +1.00] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.60 | [+0.51, +0.70] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.57 | [+0.37, +0.77] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.44 | [+0.40, +0.49] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.40 | [+0.35, +0.46] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.17 | [+0.01, +0.33] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.16 | [+0.10, +0.22] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.10 | [+0.04, +0.15] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.09 | [+0.01, +0.16] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.04 | [-0.19, +0.28] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.46, +0.54] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.01, +0.08] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.03 | [-0.19, +0.25] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.11, +0.15] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.12, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.45, +0.43] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.43, +0.32] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.08 | [-0.17, +0.01] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.17 | [-0.32, -0.01] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.28 | [-0.31, -0.24] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -1.84 | [-3.35, -0.33] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -2.91 | [-5.93, +0.12] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
|
||
| .on_otel_components_changes: | ||
| - !reference [.except_mergequeue] | ||
| - !reference [.on_main] |
There was a problem hiding this comment.
This means your jobs will only run on main (i.e. after the PR is merged). Is this expected, or do you want the build to run on PRs as well ?
There was a problem hiding this comment.
Yes that's intended, we wanted this PR to mainly run on our team's PRs and also main to make sure that the state on main is good (context). I believe it will also run on PRs with the filepath changes, since it ran on this PR
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
datadog_otel_components_ocb_buildintegration test job that was previously disabled.on_otel_components_changesrule anchor that runs the job on main merges and on changes tocmd/otel-agent/**/*,comp/otelcol/**/*, ortest/otel/testdata/**/*Motivation
Describe how you validated your changes
Additional Notes