Skip to content

[AGENTRUN-1010] InitConfigObject has to lock to avoid test flakiness#46656

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
dustin.long/flaky-config-init
Feb 23, 2026
Merged

[AGENTRUN-1010] InitConfigObject has to lock to avoid test flakiness#46656
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
dustin.long/flaky-config-init

Conversation

@dustmop
Copy link
Contributor

@dustmop dustmop commented Feb 19, 2026

What does this PR do?

Lock assignments to the global config references datadog and systemProbe during InitConfigObjects. Although this isn't needed for running the agent, it prevents the tests from being flaky, since the tests do lock accesses to these globals.

Motivation

Fix flaky tests.

Describe how you validated your changes

CI passing should be sufficient.

Additional Notes

@dustmop dustmop requested a review from a team as a code owner February 19, 2026 00:54
@dustmop dustmop added the qa/done QA done before merge and regressions are covered by tests label Feb 19, 2026
@dustmop dustmop requested a review from s-alad February 19, 2026 00:54
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Feb 19, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 19, 2026
@dustmop dustmop force-pushed the dustin.long/flaky-config-init branch from 74ccc1c to 20979fa Compare February 19, 2026 01:08
@dustmop dustmop force-pushed the dustin.long/flaky-config-init branch from 20979fa to 7d2438f Compare February 19, 2026 01:35
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 19, 2026 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d37115c
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 +12.0 KiB (0.00% increase) 756.616 → 756.628 → 759.670
✅ agent_deb_amd64_fips +8.0 KiB (0.00% increase) 715.122 → 715.130 → 720.180
✅ agent_msi +11.5 KiB (0.00% increase) 622.700 → 622.711 → 1073.220
✅ agent_rpm_amd64 +12.0 KiB (0.00% increase) 756.600 → 756.611 → 759.640
✅ agent_rpm_amd64_fips +8.0 KiB (0.00% increase) 715.106 → 715.113 → 720.160
✅ agent_rpm_arm64 +4.0 KiB (0.00% increase) 734.722 → 734.725 → 741.840
✅ agent_rpm_arm64_fips +16.0 KiB (0.00% increase) 696.240 → 696.256 → 703.390
✅ agent_suse_amd64 +12.0 KiB (0.00% increase) 756.600 → 756.611 → 759.640
✅ agent_suse_amd64_fips +8.0 KiB (0.00% increase) 715.106 → 715.113 → 720.160
✅ agent_suse_arm64 +4.0 KiB (0.00% increase) 734.722 → 734.725 → 741.840
✅ agent_suse_arm64_fips +16.0 KiB (0.00% increase) 696.240 → 696.256 → 703.390
✅ docker_agent_amd64 +12.0 KiB (0.00% increase) 817.637 → 817.649 → 821.990
✅ docker_agent_arm64 +4.0 KiB (0.00% increase) 820.494 → 820.498 → 828.520
✅ docker_agent_jmx_amd64 +12.0 KiB (0.00% increase) 1008.548 → 1008.560 → 1012.870
✅ docker_agent_jmx_arm64 +4.0 KiB (0.00% increase) 1000.188 → 1000.192 → 1008.120
✅ docker_dogstatsd_amd64 +4.0 KiB (0.01% increase) 38.500 → 38.504 → 39.380
✅ iot_agent_deb_amd64 +4.0 KiB (0.01% increase) 42.609 → 42.613 → 43.290
✅ iot_agent_deb_arm64 +4.0 KiB (0.01% increase) 39.710 → 39.714 → 40.920
✅ iot_agent_rpm_amd64 +4.0 KiB (0.01% increase) 42.609 → 42.613 → 43.290
✅ iot_agent_suse_amd64 +4.0 KiB (0.01% increase) 42.609 → 42.613 → 43.290
11 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_heroku_amd64 323.758 MiB
✅ docker_cluster_agent_amd64 203.414 MiB
✅ docker_cluster_agent_arm64 217.834 MiB
✅ docker_cws_instrumentation_amd64 7.135 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_arm64 36.812 MiB
✅ dogstatsd_deb_amd64 29.724 MiB
✅ dogstatsd_deb_arm64 27.881 MiB
✅ dogstatsd_rpm_amd64 29.724 MiB
✅ dogstatsd_suse_amd64 29.724 MiB
✅ iot_agent_deb_armhf 40.439 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 -38.52 KiB (0.02% reduction) 185.720 → 185.683 → 186.090
✅ agent_deb_amd64_fips -6.02 KiB (0.00% reduction) 176.297 → 176.291 → 180.330
✅ agent_heroku_amd64 +7.9 KiB (0.01% increase) 87.104 → 87.112 → 88.440
✅ agent_msi +12.0 KiB (0.01% increase) 149.320 → 149.332 → 154.470
✅ agent_rpm_amd64 +8.91 KiB (0.00% increase) 187.599 → 187.608 → 189.170
✅ agent_rpm_amd64_fips +5.25 KiB (0.00% increase) 178.417 → 178.422 → 181.060
✅ agent_rpm_arm64 +104.3 KiB (0.06% increase) 169.822 → 169.923 → 170.020
✅ agent_rpm_arm64_fips +2.55 KiB (0.00% increase) 162.484 → 162.487 → 164.130
✅ agent_suse_amd64 +8.91 KiB (0.00% increase) 187.599 → 187.608 → 189.170
✅ agent_suse_amd64_fips +5.25 KiB (0.00% increase) 178.417 → 178.422 → 181.060
✅ agent_suse_arm64 +104.3 KiB (0.06% increase) 169.822 → 169.923 → 170.020
✅ agent_suse_arm64_fips +2.55 KiB (0.00% increase) 162.484 → 162.487 → 164.130
✅ docker_agent_amd64 +3.98 KiB (0.00% increase) 277.909 → 277.913 → 279.410
✅ docker_agent_arm64 +2.81 KiB (0.00% increase) 265.186 → 265.189 → 267.960
✅ docker_agent_jmx_amd64 +5.98 KiB (0.00% increase) 346.548 → 346.554 → 348.040
✅ docker_agent_jmx_arm64 neutral 329.829 MiB → 332.560
✅ docker_cluster_agent_amd64 neutral 71.196 MiB → 71.920
✅ docker_cluster_agent_arm64 +9.15 KiB (0.01% increase) 66.834 → 66.843 → 67.220
✅ docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 14.901 MiB → 15.820
✅ docker_dogstatsd_arm64 +2.7 KiB (0.02% increase) 14.237 → 14.239 → 14.830
✅ dogstatsd_deb_amd64 neutral 7.855 MiB → 8.790
✅ dogstatsd_deb_arm64 neutral 6.742 MiB → 7.710
✅ dogstatsd_rpm_amd64 neutral 7.866 MiB → 8.800
✅ dogstatsd_suse_amd64 neutral 7.866 MiB → 8.800
✅ iot_agent_deb_amd64 neutral 11.233 MiB → 12.040
✅ iot_agent_deb_arm64 neutral 9.598 MiB → 10.450
✅ iot_agent_deb_armhf neutral 9.801 MiB → 10.620
✅ iot_agent_rpm_amd64 neutral 11.251 MiB → 12.060
✅ iot_agent_suse_amd64 neutral 11.251 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Feb 19, 2026 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 964ab63f-9921-4bbe-993b-7de96f4fc84c

Baseline: 8d7bcf5
Comparison: bef2fe1
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +3.26 [+0.18, +6.34] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +4.52 [+3.00, +6.03] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization +3.26 [+0.18, +6.34] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +1.42 [+1.34, +1.50] 1 Logs
➖ otlp_ingest_logs memory utilization +0.89 [+0.79, +0.99] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.38 [+0.34, +0.42] 1 Logs bounds checks dashboard
➖ otlp_ingest_metrics memory utilization +0.24 [+0.09, +0.39] 1 Logs
➖ ddot_metrics memory utilization +0.22 [+0.00, +0.44] 1 Logs
➖ ddot_logs memory utilization +0.17 [+0.11, +0.23] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.10 [+0.05, +0.15] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.04 [-0.11, +0.19] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.02 [-0.37, +0.40] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.48, +0.50] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.09, +0.09] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.13] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.05, +0.03] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.10] 1 Logs
➖ ddot_metrics_sum_delta memory utilization -0.02 [-0.22, +0.19] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.45, +0.41] 1 Logs
➖ file_tree memory utilization -0.03 [-0.08, +0.03] 1 Logs
➖ quality_gate_idle memory utilization -0.15 [-0.19, -0.11] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -0.25 [-0.33, -0.18] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.28 [-0.51, -0.04] 1 Logs
➖ quality_gate_metrics_logs memory utilization -2.12 [-2.33, -1.92] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@Enzu83 Enzu83 mentioned this pull request Feb 19, 2026
Closed
@dustmop
Copy link
Contributor Author

dustmop commented Feb 23, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 23, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-02-23 19:50:07 UTC ℹ️ Start processing command /merge

2026-02-23 19:50:13 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2026-02-23 20:30:43 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit af5ea78 into main Feb 23, 2026
291 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the dustin.long/flaky-config-init branch February 23, 2026 20:30
@github-actions github-actions bot added this to the 7.78.0 milestone Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-alad s-alad s-alad approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration

Projects

None yet

Milestone

7.78.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dustmop @s-alad