Skip to content

[Backport 7.77.x] fix(workloadselection): allow file overwrite after ACL setting on Windows#46816

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.77.xfrom
backport-46712-to-7.77.x
Feb 23, 2026
Merged

[Backport 7.77.x] fix(workloadselection): allow file overwrite after ACL setting on Windows#46816
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.77.xfrom
backport-46712-to-7.77.x

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Feb 23, 2026

Backport 9fac229 from #46712.


What does this PR do?

Fix a bug that caused the agent to not be able to change the workload selection policy after having created it because it set permissions that were too restrictive.

Motivation

Describe how you validated your changes

Unit test

Additional Notes

…dows (#46712) ### What does this PR do?

Fix a bug that caused the agent to not be able to change the workload selection policy after having created it because it set permissions that were too restrictive.

### Motivation

### Describe how you validated your changes

Unit test

### Additional Notes

Co-authored-by: bertrand.mermet <bertrand.mermet@datadoghq.com>
(cherry picked from commit 9fac229)

___

Co-authored-by: Bertrand Mermet <bertrand.mermet@datadoghq.com>
@dd-octo-sts dd-octo-sts bot requested review from a team as code owners February 23, 2026 15:18
@dd-octo-sts dd-octo-sts bot added backport bot internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/injection-platform labels Feb 23, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 23, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6ca22bc
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 755.986 MiB
agent_deb_amd64_fips 715.075 MiB
agent_heroku_amd64 323.755 MiB
agent_msi 622.074 MiB
agent_rpm_amd64 755.970 MiB
agent_rpm_amd64_fips 715.059 MiB
agent_rpm_arm64 734.127 MiB
agent_rpm_arm64_fips 696.202 MiB
agent_suse_amd64 755.970 MiB
agent_suse_amd64_fips 715.059 MiB
agent_suse_arm64 734.127 MiB
agent_suse_arm64_fips 696.202 MiB
docker_agent_amd64 817.007 MiB
docker_agent_arm64 819.899 MiB
docker_agent_jmx_amd64 1007.919 MiB
docker_agent_jmx_arm64 999.593 MiB
docker_cluster_agent_amd64 202.999 MiB
docker_cluster_agent_arm64 217.454 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.500 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.720 MiB
dogstatsd_deb_arm64 27.881 MiB
dogstatsd_rpm_amd64 29.720 MiB
dogstatsd_suse_amd64 29.720 MiB
iot_agent_deb_amd64 42.617 MiB
iot_agent_deb_arm64 39.723 MiB
iot_agent_deb_armhf 40.447 MiB
iot_agent_rpm_amd64 42.618 MiB
iot_agent_suse_amd64 42.618 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -41.12 KiB (0.02% reduction) 185.463 → 185.423 → 186.090
agent_deb_amd64_fips -8.02 KiB (0.00% reduction) 176.280 → 176.272 → 180.330
agent_heroku_amd64 -3.3 KiB (0.00% reduction) 87.106 → 87.103 → 88.440
agent_msi +8.0 KiB (0.01% increase) 149.234 → 149.242 → 154.470
agent_rpm_amd64 +33.49 KiB (0.02% increase) 187.283 → 187.316 → 189.170
agent_rpm_amd64_fips +12.63 KiB (0.01% increase) 178.401 → 178.413 → 181.060
agent_rpm_arm64 +19.46 KiB (0.01% increase) 169.741 → 169.760 → 170.020
agent_rpm_arm64_fips +5.91 KiB (0.00% increase) 162.478 → 162.484 → 164.130
agent_suse_amd64 +33.49 KiB (0.02% increase) 187.283 → 187.316 → 189.170
agent_suse_amd64_fips +12.63 KiB (0.01% increase) 178.401 → 178.413 → 181.060
agent_suse_arm64 +19.46 KiB (0.01% increase) 169.741 → 169.760 → 170.020
agent_suse_arm64_fips +5.91 KiB (0.00% increase) 162.478 → 162.484 → 164.130
docker_agent_amd64 neutral 277.757 MiB → 279.410
docker_agent_arm64 +3.56 KiB (0.00% increase) 265.043 → 265.046 → 267.960
docker_agent_jmx_amd64 neutral 346.398 MiB → 348.040
docker_agent_jmx_arm64 neutral 329.698 MiB → 332.560
docker_cluster_agent_amd64 neutral 71.130 MiB → 71.920
docker_cluster_agent_arm64 neutral 66.770 MiB → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.900 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.239 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.853 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.741 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.865 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.865 MiB → 8.800
iot_agent_deb_amd64 neutral 11.238 MiB → 12.040
iot_agent_deb_arm64 +2.02 KiB (0.02% increase) 9.601 → 9.603 → 10.450
iot_agent_deb_armhf -2.08 KiB (0.02% reduction) 9.805 → 9.803 → 10.620
iot_agent_rpm_amd64 neutral 11.253 MiB → 12.060
iot_agent_suse_amd64 neutral 11.253 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Feb 23, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2061f5c9-5152-4621-94f9-64a897e1ffb5

Baseline: cded3a1
Comparison: 941b984
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.96 [-1.13, +5.05] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.96 [-1.13, +5.05] 1 Logs
file_tree memory utilization +0.29 [+0.23, +0.34] 1 Logs
otlp_ingest_logs memory utilization +0.20 [+0.10, +0.30] 1 Logs
ddot_metrics_sum_delta memory utilization +0.19 [+0.00, +0.38] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.13 [-0.03, +0.29] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.10 [-0.27, +0.47] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.06 [-0.00, +0.11] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.02 [-0.21, +0.26] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.44, +0.44] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.09] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.12] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.13, +0.13] 1 Logs
quality_gate_idle memory utilization -0.04 [-0.08, +0.00] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.10, -0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.12 [-0.59, +0.36] 1 Logs
quality_gate_metrics_logs memory utilization -0.23 [-0.44, -0.01] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.23 [-0.45, -0.01] 1 Logs
docker_containers_memory memory utilization -0.25 [-0.32, -0.17] 1 Logs
ddot_logs memory utilization -0.28 [-0.33, -0.22] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.30 [-0.39, -0.21] 1 Logs
otlp_ingest_metrics memory utilization -0.30 [-0.46, -0.15] 1 Logs
quality_gate_idle_all_features memory utilization -0.43 [-0.47, -0.39] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.57 [-2.07, +0.94] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit db05bde into 7.77.x Feb 23, 2026
352 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the backport-46712-to-7.77.x branch February 23, 2026 18:06
@github-actions github-actions bot added this to the 7.77.0 milestone Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bot internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/injection-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants