Skip to content

logs: remove health platform references from Logs Agent#46818

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
louis-cqrl/AH-remove-deprecated-health-platform-issue
Feb 23, 2026
Merged

logs: remove health platform references from Logs Agent#46818
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
louis-cqrl/AH-remove-deprecated-health-platform-issue

Conversation

@louis-cqrl
Copy link
Contributor

What does this PR do?

Removes the Logs Agent’s integration with the Health Platform that was used to report Docker file tailing permission issues. Concretely, this PR:

  • Drops the healthplatform dependency wiring from the logs agent component.
  • Simplifies the container launcher and tailer factory constructors by removing the healthPlatform parameter.
  • Removes the Docker file permission error detection and reporting code path (including the issue reporting helper functions).
  • Updates mocks and unit tests to reflect the removal.

Motivation

The Logs Agent should no longer mention or depend on the Health Platform for reporting issues in this flow as it is now a built-in check of the platform

Describe how you validated your changes

  • Ran unit tests for the logs agent / container launcher / tailer factory packages (including updated tests in pkg/logs/launchers/container/...).
  • Ensured the agent compiles with the updated constructor signatures and fx wiring changes.

Additional Notes

@louis-cqrl louis-cqrl added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 23, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-log-pipelines labels Feb 23, 2026
@louis-cqrl louis-cqrl requested a review from pducolin February 23, 2026 15:34
@github-actions github-actions bot added the medium review PR review might take time label Feb 23, 2026
@louis-cqrl louis-cqrl requested a review from a team February 23, 2026 15:34
@louis-cqrl louis-cqrl added the ask-review Ask required teams to review this PR label Feb 23, 2026
@pducolin
Copy link
Collaborator

Can you also ensure the e2e test succeed?

@louis-cqrl
Copy link
Contributor Author

Can you also ensure the e2e test succeed?

@pducolin yes for sure this is already running in local but I will also run it on the CI

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7747810
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +559.12 KiB (0.07% increase) 756.058 → 756.604 → 759.670
agent_deb_amd64_fips +17.62 KiB (0.00% increase) 715.093 → 715.110 → 720.180
agent_msi +589.37 KiB (0.09% increase) 622.113 → 622.689 → 1073.220
agent_rpm_amd64 +559.12 KiB (0.07% increase) 756.042 → 756.588 → 759.640
agent_rpm_amd64_fips +17.62 KiB (0.00% increase) 715.077 → 715.094 → 720.160
agent_rpm_arm64 +521.53 KiB (0.07% increase) 734.189 → 734.698 → 741.840
agent_rpm_arm64_fips +20.03 KiB (0.00% increase) 696.217 → 696.236 → 703.390
agent_suse_amd64 +559.12 KiB (0.07% increase) 756.042 → 756.588 → 759.640
agent_suse_amd64_fips +17.62 KiB (0.00% increase) 715.077 → 715.094 → 720.160
agent_suse_arm64 +521.53 KiB (0.07% increase) 734.189 → 734.698 → 741.840
agent_suse_arm64_fips +20.03 KiB (0.00% increase) 696.217 → 696.236 → 703.390
docker_agent_amd64 +559.12 KiB (0.07% increase) 817.079 → 817.625 → 821.990
docker_agent_arm64 +521.53 KiB (0.06% increase) 819.961 → 820.470 → 828.520
docker_agent_jmx_amd64 +559.12 KiB (0.05% increase) 1007.991 → 1008.537 → 1012.870
docker_agent_jmx_arm64 +521.53 KiB (0.05% increase) 999.655 → 1000.164 → 1008.120
docker_cluster_agent_amd64 +388.8 KiB (0.19% increase) 203.030 → 203.410 → 204.270
docker_cluster_agent_arm64 +388.81 KiB (0.17% increase) 217.454 → 217.834 → 218.000
docker_dogstatsd_amd64 +4.0 KiB (0.01% increase) 38.496 → 38.500 → 39.380
dogstatsd_deb_arm64 +4.0 KiB (0.01% increase) 27.877 → 27.881 → 29.110
iot_agent_deb_amd64 -12.66 KiB (0.03% reduction) 42.617 → 42.605 → 43.290
iot_agent_deb_arm64 -8.66 KiB (0.02% reduction) 39.719 → 39.710 → 40.920
iot_agent_deb_armhf -12.57 KiB (0.03% reduction) 40.447 → 40.435 → 41.030
iot_agent_rpm_amd64 -12.66 KiB (0.03% reduction) 42.618 → 42.605 → 43.290
iot_agent_suse_amd64 -12.66 KiB (0.03% reduction) 42.618 → 42.605 → 43.290
7 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_heroku_amd64 323.754 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.720 MiB
dogstatsd_rpm_amd64 29.720 MiB
dogstatsd_suse_amd64 29.720 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +165.5 KiB (0.09% increase) 185.523 → 185.684 → 186.090
agent_deb_amd64_fips +23.68 KiB (0.01% increase) 176.270 → 176.294 → 180.330
agent_heroku_amd64 neutral 87.105 MiB → 88.440
agent_msi +76.0 KiB (0.05% increase) 149.242 → 149.316 → 154.470
agent_rpm_amd64 +163.41 KiB (0.09% increase) 187.394 → 187.554 → 189.170
agent_rpm_amd64_fips -15.48 KiB (0.01% reduction) 178.450 → 178.435 → 181.060
agent_rpm_arm64 +144.21 KiB (0.08% increase) 169.756 → 169.897 → 170.020
agent_rpm_arm64_fips +48.13 KiB (0.03% increase) 162.465 → 162.512 → 164.130
agent_suse_amd64 +163.41 KiB (0.09% increase) 187.394 → 187.554 → 189.170
agent_suse_amd64_fips -15.48 KiB (0.01% reduction) 178.450 → 178.435 → 181.060
agent_suse_arm64 +144.21 KiB (0.08% increase) 169.756 → 169.897 → 170.020
agent_suse_arm64_fips +48.13 KiB (0.03% increase) 162.465 → 162.512 → 164.130
docker_agent_amd64 +131.26 KiB (0.05% increase) 277.778 → 277.906 → 279.410
docker_agent_arm64 +117.26 KiB (0.04% increase) 265.061 → 265.175 → 267.960
docker_agent_jmx_amd64 +137.52 KiB (0.04% increase) 346.426 → 346.560 → 348.040
docker_agent_jmx_arm64 +99.19 KiB (0.03% increase) 329.702 → 329.799 → 332.560
docker_cluster_agent_amd64 +59.49 KiB (0.08% increase) 71.137 → 71.195 → 71.920
docker_cluster_agent_arm64 +50.46 KiB (0.07% increase) 66.777 → 66.826 → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.900 MiB → 15.820
docker_dogstatsd_arm64 +6.14 KiB (0.04% increase) 14.233 → 14.239 → 14.830
dogstatsd_deb_amd64 neutral 7.853 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.740 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.866 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.866 MiB → 8.800
iot_agent_deb_amd64 -6.17 KiB (0.05% reduction) 11.239 → 11.233 → 12.040
iot_agent_deb_arm64 -4.54 KiB (0.05% reduction) 9.602 → 9.597 → 10.450
iot_agent_deb_armhf -3.95 KiB (0.04% reduction) 9.804 → 9.800 → 10.620
iot_agent_rpm_amd64 -6.07 KiB (0.05% reduction) 11.257 → 11.251 → 12.060
iot_agent_suse_amd64 -6.07 KiB (0.05% reduction) 11.257 → 11.251 → 12.060

@cit-pr-commenter-54b7da
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ab143085-c7bd-4354-bbbe-e51b522dfcee

Baseline: 38bb585
Comparison: 221acf6
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.64 [-1.51, +4.80] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.64 [-1.51, +4.80] 1 Logs
ddot_metrics memory utilization +0.73 [+0.52, +0.95] 1 Logs
file_tree memory utilization +0.42 [+0.37, +0.47] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.29 [+0.06, +0.52] 1 Logs
ddot_logs memory utilization +0.13 [+0.07, +0.20] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.12 [+0.07, +0.17] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.31, +0.45] 1 Logs
otlp_ingest_metrics memory utilization +0.06 [-0.09, +0.22] 1 Logs
quality_gate_idle memory utilization +0.06 [+0.01, +0.10] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.04 [-0.05, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.03, +0.06] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.03, +0.05] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.09] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.13, +0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.44, +0.41] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.51, +0.45] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.29 [-0.45, -0.13] 1 Logs
otlp_ingest_logs memory utilization -0.35 [-0.44, -0.25] 1 Logs
quality_gate_metrics_logs memory utilization -0.42 [-0.64, -0.20] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.84 [-1.04, -0.63] 1 Logs
quality_gate_logs % cpu utilization -1.36 [-2.86, +0.14] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.55 [-1.63, -1.47] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 058e777 into main Feb 23, 2026
345 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the louis-cqrl/AH-remove-deprecated-health-platform-issue branch February 23, 2026 18:48
@github-actions github-actions bot added this to the 7.78.0 milestone Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-log-pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants